unofficial mirror of emacs-orgmode@gnu.org
 help / color / Atom feed
* Inconsistent behaviour: toggle inline images does not work with relative paths [9.3.7 (9.3.7-2-g706970-elpa @ /Users/matthijs/.emacs.d/elpa/org-20200608/)]
@ 2020-06-11 10:35 Matthijs de Jonge
  2020-06-13 16:06 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Matthijs de Jonge @ 2020-06-11 10:35 UTC (permalink / raw)
  To: emacs-orgmode

Hi all,

Today I ran into some behavior that seemed strange to me:

I have inline images:

[[file:relative/path/from/org-file.png]]

With org-startup-with-inline-images these work as expected.

What does not work as expected is org-toggle-inline-images : this does
not disable inline image preview (though it does *enable* it).

However, when you change the path to:

[[file:./relative/path/from/org-file.png]]

It does work as expected. You need to explicitly add the initial dot
slash.

Since org is perfectly capable of displaying images without the initial
dot slash, the behavior of org-toggle-inline-images seems to be a bit
inconsistent.


Kind regards,

Matthijs de Jonge




Emacs  : GNU Emacs 26.3 (build 1, x86_64-apple-darwin18.2.0, NS appkit-1671.20 Version 10.14.3 (Build 18D109))
 of 2019-09-02
Package: Org mode version 9.3.7 (9.3.7-2-g706970-elpa @ /Users/matthijs/.emacs.d/elpa/org-20200608/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-link-shell-confirm-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-html-format-inlinetask-function 'org-html-format-inlinetask-default-function
 org-src-tab-acts-natively t
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-imenu-depth 5
 org-agenda-files '("~/Dropbox/00_db/boeken.txt" "~/Dropbox/00_db/boodschappenlijst.txt"
                    "~/Dropbox/00_db/building_a_second_brain.txt" "~/Dropbox/00_db/cadeaus.txt"
                    "~/Dropbox/00_db/curiosa.txt" "~/Dropbox/00_db/dingen.txt" "~/Dropbox/00_db/downloaden.txt"
                    "~/Dropbox/00_db/dromen.txt" "~/Dropbox/00_db/electronica.txt" "~/Dropbox/00_db/emacs.txt"
                    "~/Dropbox/00_db/fiets.txt" "~/Dropbox/00_db/go.txt" "~/Dropbox/00_db/hardlopen.txt"
                    "~/Dropbox/00_db/hoofdpijn.txt" "~/Dropbox/00_db/huishouden.txt" "~/Dropbox/00_db/inbox.txt"
                    "~/Dropbox/00_db/kijken.txt" "~/Dropbox/00_db/kleren.txt" "~/Dropbox/00_db/koffie.txt"
                    "~/Dropbox/00_db/koken.txt" "~/Dropbox/00_db/krachttraining.txt" "~/Dropbox/00_db/kunst.txt"
                    "~/Dropbox/00_db/leren.txt" "~/Dropbox/00_db/monsters.txt" "~/Dropbox/00_db/muziek.txt"
                    "~/Dropbox/00_db/muziekmaken.txt" "~/Dropbox/00_db/muziekquiz.txt"
                    "~/Dropbox/00_db/onderwijs.txt" "~/Dropbox/00_db/planten.txt" "~/Dropbox/00_db/quizvragen.txt"
                    "~/Dropbox/00_db/racket-sequencer.txt" "~/Dropbox/00_db/rijmpjes.txt"
                    "~/Dropbox/00_db/sleutels.txt" "~/Dropbox/00_db/stretching mobility.txt"
                    "~/Dropbox/00_db/strips.txt" "~/Dropbox/00_db/suriname.txt" "~/Dropbox/00_db/tech.txt"
                    "~/Dropbox/00_db/tekenen.txt" "~/Dropbox/00_db/todo.txt" "~/Dropbox/00_db/treinen.txt"
                    "~/Dropbox/00_db/verjaardagen.txt" "~/Dropbox/00_db/vogels.txt" "~/Dropbox/00_db/vrijetijd.txt"
                    "~/Dropbox/00_db/weekoverzicht.txt" "~/Dropbox/00_db/werk.txt" "~/Dropbox/00_db/wiskunde.txt"
                    "~/Dropbox/00_db/woorden.txt")
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-mode-hook '((lambda nil (imenu-add-to-menubar "Imenu"))
                 #[0 "\301\211\x10\207" [imenu-create-index-function org-imenu-get-tree] 2]
                 (lambda nil (variable-pitch-mode 1) (setq line-spacing 0.2)
                  (mapcar (function (lambda (face) (set-face-attribute face nil :inherit (quote fixed-pitch))))
                   (quote
                    (org-block org-table org-meta-line org-document-title org-document-info-keyword org-date
                     org-special-keyword org-drawer org-property-value)
                    )
                   )
                  )
                 (lambda nil (org-bullets-mode 1))
                 #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-all append local] 5]
                 #[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes (lambda nil (flyspell-mode 1)))
 org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-startup-indented t
 org-startup-with-inline-images t
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300\x01\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
 org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-babel-load-languages '((python . t) (racket . t) (emacs-lisp . t))
 org-ascii-format-drawer-function #[771 "\x01\207" [] 4 "\n\n(fn NAME CONTENTS WIDTH)"]
 org-ellipsis " ⤵"
 org-babel-python-command "python3"
 org-src-preserve-indentation t
 org-catch-invisible-edits 'show-and-error
 org-occur-hook '(org-first-headline-recenter)
 org-structure-template-alist '(("c" . "center") ("e" . "example") ("l" . "src emacs-lisp")
                                ("p" . "src python :session") ("q" . "quote") ("r" . "src racket"))
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-todo-keywords '((sequence "TODO" "|" "DONE(!)") (sequence "|" "WAIT(!)"))
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
 org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
 org-babel-tangle-lang-exts '(("python" . "py") ("racket" . "rkt") ("emacs-lisp" . "el") ("elisp" . "el"))
 org-return-follows-link t
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("attachment" :follow org-attach-open-link :export org-attach-export-link :complete
                        org-attach-complete-link)
                       ("id" :follow org-id-open) ("eww" :follow eww :store org-eww-store-link)
                       ("rmail" :follow org-rmail-open :store org-rmail-store-link)
                       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
                       ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export)
                       ("info" :follow org-info-open :export org-info-export :store org-info-store-link)
                       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
                       ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link)
                       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
                       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link
                        :store org-bbdb-store-link)
                       ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
                       ("shell" :follow org-link--open-shell)
                       ("news" :follow #[257 "\301\300\302\x03Q!\207" ["news" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("mailto" :follow #[257 "\301\300\302\x03Q!\207" ["mailto" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("https" :follow #[257 "\301\300\302\x03Q!\207" ["https" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("http" :follow #[257 "\301\300\302\x03Q!\207" ["http" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("ftp" :follow #[257 "\301\300\302\x03Q!\207" ["ftp" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("help" :follow org-link--open-help) ("file" :complete org-link-complete-file)
                       ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi))
 org-latex-format-headline-function 'org-latex-format-headline-default-function
 org-link-elisp-confirm-function 'yes-or-no-p
 org-latex-format-inlinetask-function 'org-latex-format-inlinetask-default-function
 org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-html-format-headline-function 'org-html-format-headline-default-function
 org-src-window-setup 'current-window
 org-confirm-babel-evaluate nil
 org-agenda-custom-commands '(("l" "Lezen" tags "lezen")
                              ("t" "TODO" ((agenda "" ((org-agenda-span 1))) (todo "TODO"))
                               ((org-agenda-files (remove "~/Dropbox/00_db/werk.txt" org-agenda-files))))
                              ("w" "Alleen werk" ((agenda "" ((org-agenda-span 1))) (todo "TODO"))
                               ((org-agenda-files (quote ("~/Dropbox/00_db/werk.txt")))))
                              )
 org-agenda-todo-ignore-scheduled 'all
 org-default-notes-file "~/Dropbox/00_db/inbox.txt"
 )



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Inconsistent behaviour: toggle inline images does not work with relative paths [9.3.7 (9.3.7-2-g706970-elpa @ /Users/matthijs/.emacs.d/elpa/org-20200608/)]
  2020-06-11 10:35 Inconsistent behaviour: toggle inline images does not work with relative paths [9.3.7 (9.3.7-2-g706970-elpa @ /Users/matthijs/.emacs.d/elpa/org-20200608/)] Matthijs de Jonge
@ 2020-06-13 16:06 ` Nicolas Goaziou
  2020-06-13 18:37   ` Matthijs de Jonge
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2020-06-13 16:06 UTC (permalink / raw)
  To: Matthijs de Jonge; +Cc: emacs-orgmode

Hello,

Matthijs de Jonge <rhmtts@gmail.com> writes:

> Today I ran into some behavior that seemed strange to me:
>
> I have inline images:
>
> [[file:relative/path/from/org-file.png]]
>
> With org-startup-with-inline-images these work as expected.
>
> What does not work as expected is org-toggle-inline-images : this does
> not disable inline image preview (though it does *enable* it).

I cannot reproduce it. Calling `org-toggle-inline-images' twice bring me
back to link text. Could you try again with a minimal setup?

Regards,
-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Inconsistent behaviour: toggle inline images does not work with relative paths [9.3.7 (9.3.7-2-g706970-elpa @ /Users/matthijs/.emacs.d/elpa/org-20200608/)]
  2020-06-13 16:06 ` Nicolas Goaziou
@ 2020-06-13 18:37   ` Matthijs de Jonge
  0 siblings, 0 replies; 3+ messages in thread
From: Matthijs de Jonge @ 2020-06-13 18:37 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

Hello,

Very strange. I cannot now reproduce it either.

Might be because I updated some packages in the meantime or something.

Guess next time I come across it I’ll need to dive into the org-toggle-inline-images function myself to see what’s going on.

Sorry for keeping you busy.

Regards, 

Matthijs de Jonge

> Op 13 jun. 2020, om 18:06 heeft Nicolas Goaziou <mail@nicolasgoaziou.fr> het volgende geschreven:
> 
> Hello,
> 
> Matthijs de Jonge <rhmtts@gmail.com> writes:
> 
>> Today I ran into some behavior that seemed strange to me:
>> 
>> I have inline images:
>> 
>> [[file:relative/path/from/org-file.png]]
>> 
>> With org-startup-with-inline-images these work as expected.
>> 
>> What does not work as expected is org-toggle-inline-images : this does
>> not disable inline image preview (though it does *enable* it).
> 
> I cannot reproduce it. Calling `org-toggle-inline-images' twice bring me
> back to link text. Could you try again with a minimal setup?
> 
> Regards,
> -- 
> Nicolas Goaziou



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 10:35 Inconsistent behaviour: toggle inline images does not work with relative paths [9.3.7 (9.3.7-2-g706970-elpa @ /Users/matthijs/.emacs.d/elpa/org-20200608/)] Matthijs de Jonge
2020-06-13 16:06 ` Nicolas Goaziou
2020-06-13 18:37   ` Matthijs de Jonge

unofficial mirror of emacs-orgmode@gnu.org

Archives are clonable:
	git clone --mirror https://yhetil.org/orgmode/0 orgmode/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 orgmode orgmode/ https://yhetil.org/orgmode \
		emacs-orgmode@gnu.org
	public-inbox-index orgmode

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.orgmode
	nntp://news.gmane.io/gmane.emacs.orgmode


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git