unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Milton Vandersloot <miltonrobertvandersloot1412@protonmail.com>
To: "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Mark test "error message from query_search_messages" (T060-count.sh) to require GDB
Date: Sun, 05 Apr 2020 08:38:27 +0000	[thread overview]
Message-ID: <ztMWvyn1Vw0FloPT7NYTkFoY9Fm1Ez4YgMfYh99Te-Y6yXRtAXuEIfVrodhRKDSxjg-zOJa_RTQ68AtSbSO-ESla5BFLfG7sw5RTGRhEQwI=@protonmail.com> (raw)

Dear notmuch Developers

The test "error message from query_search_messages" in test/T060-count.sh needs GDB as external dependency but does not advocate so.
Below a sed script adding the requirement.

I have used ${TEST_GDB} here as this is the expression used in test/test-lib.sh at the end.
However, the test code base also has occurrences of "test_require_external_prereq gdb" (use grep or similar to find those).
I don't know which is the correct form but they should probably be unified.

Regards
Milton

# Mark tests properly which need GDB
sed -e "/test_begin_subtest [\"']error message from query_search_messages[\"']/ a test_require_external_prereq \\\${TEST_GDB}" \
	-i test/T060-count.sh || die

             reply	other threads:[~2020-04-05 19:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05  8:38 Milton Vandersloot [this message]
2021-08-02 19:18 ` [PATCH 1/2] test/count: mark subtests needing gdb David Bremner
2021-08-02 19:18   ` [PATCH 2/2] test/atomicity: use ${TEST_GDB} in prereq test David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ztMWvyn1Vw0FloPT7NYTkFoY9Fm1Ez4YgMfYh99Te-Y6yXRtAXuEIfVrodhRKDSxjg-zOJa_RTQ68AtSbSO-ESla5BFLfG7sw5RTGRhEQwI=@protonmail.com' \
    --to=miltonrobertvandersloot1412@protonmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).