unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Milton Vandersloot <miltonrobertvandersloot1412@protonmail.com>,
	"notmuch@notmuchmail.org" <notmuch@notmuchmail.org>
Cc: David Bremner <david@tethera.net>
Subject: [PATCH 1/2] test/count: mark subtests needing gdb.
Date: Mon,  2 Aug 2021 16:18:34 -0300	[thread overview]
Message-ID: <20210802191835.3337610-1-david@tethera.net> (raw)
In-Reply-To: <ztMWvyn1Vw0FloPT7NYTkFoY9Fm1Ez4YgMfYh99Te-Y6yXRtAXuEIfVrodhRKDSxjg-zOJa_RTQ68AtSbSO-ESla5BFLfG7sw5RTGRhEQwI=@protonmail.com>

The tests will otherwise fail if gdb is not installed.  Thanks to
Milton Vandersloot for pointing out the problem

[1]: id:ztMWvyn1Vw0FloPT7NYTkFoY9Fm1Ez4YgMfYh99Te-Y6yXRtAXuEIfVrodhRKDSxjg-zOJa_RTQ68AtSbSO-ESla5BFLfG7sw5RTGRhEQwI=@protonmail.com
---
 test/T060-count.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/T060-count.sh b/test/T060-count.sh
index a1ebf8ba..a1557e33 100755
--- a/test/T060-count.sh
+++ b/test/T060-count.sh
@@ -95,6 +95,7 @@ test_expect_equal_file EXPECTED OUTPUT
 
 backup_database
 test_begin_subtest "error message for database open"
+test_require_external_prereq ${TEST_GDB}
 target=(${MAIL_DIR}/.notmuch/xapian/postlist.*)
 dd if=/dev/zero of="$target" count=3
 notmuch count '*' 2>OUTPUT 1>/dev/null
@@ -116,6 +117,7 @@ EOF
 
 backup_database
 test_begin_subtest "error message from query_search_messages"
+test_require_external_prereq ${TEST_GDB}
 ${TEST_GDB} --batch-silent --return-child-result -x count-files.gdb \
     --args notmuch count --output=files '*' 2>OUTPUT 1>/dev/null
 cat <<EOF > EXPECTED
-- 
2.30.2

  reply	other threads:[~2021-08-02 19:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05  8:38 Mark test "error message from query_search_messages" (T060-count.sh) to require GDB Milton Vandersloot
2021-08-02 19:18 ` David Bremner [this message]
2021-08-02 19:18   ` [PATCH 2/2] test/atomicity: use ${TEST_GDB} in prereq test David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802191835.3337610-1-david@tethera.net \
    --to=david@tethera.net \
    --cc=miltonrobertvandersloot1412@protonmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).