[PATCH v3] Add hook inside notmuch-mua-reply

[PATCH v3] Add hook inside notmuch-mua-reply

[Sandra Snan]

This hook is run after `notmuch reply` has been successfully called
with the headers from the original message.
---
 emacs/notmuch-mua.el | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index e4b7e9d1..b6c6585d 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -44,13 +44,18 @@
 (defvar notmuch-show-max-text-part-size)
 (defvar notmuch-show-insert-text/plain-hook)
 
+(defvar notmuch-mua-reply-functions nil
+  "Functions to run after `notmuch-reply' was called successfully
+without erroring. The functions get the original message as a
+sexp."
+
 ;;; Options
 
-(defcustom notmuch-mua-send-hook nil
-  "Hook run before sending messages."
-  :type 'hook
-  :group 'notmuch-send
-  :group 'notmuch-hooks)
+  (defcustom notmuch-mua-send-hook nil
+    "Hook run before sending messages."
+    :type 'hook
+    :group 'notmuch-send
+    :group 'notmuch-hooks))
 
 (defcustom notmuch-mua-compose-in 'current-window
   "Where to create the mail buffer used to compose a new message.
@@ -256,6 +261,8 @@ Typically this is added to `notmuch-mua-send-hook'."
     ;; Extract the headers of both the reply and the original message.
     (let* ((original-headers (plist-get original :headers))
 	   (reply-headers (plist-get reply :reply-headers)))
+      ;; Run hook here with the original
+      (run-hook-with-args 'notmuch-mua-reply-functions original)
       ;; If sender is non-nil, set the From: header to its value.
       (when sender
 	(plist-put reply-headers :From sender))
-- 
2.39.2

Re: [PATCH v3] Add hook inside notmuch-mua-reply

[Tomi Ollila]

On Mon, Dec 11 2023, Sandra Snan wrote:

> This hook is run after `notmuch reply` has been successfully called
> with the headers from the original message.
> ---
>  emacs/notmuch-mua.el | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index e4b7e9d1..b6c6585d 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -44,13 +44,18 @@
>  (defvar notmuch-show-max-text-part-size)
>  (defvar notmuch-show-insert-text/plain-hook)
>  
> +(defvar notmuch-mua-reply-functions nil
> +  "Functions to run after `notmuch-reply' was called successfully
> +without erroring. The functions get the original message as a
> +sexp."
> +
>  ;;; Options
>  
> -(defcustom notmuch-mua-send-hook nil
> -  "Hook run before sending messages."
> -  :type 'hook
> -  :group 'notmuch-send
> -  :group 'notmuch-hooks)


> +  (defcustom notmuch-mua-send-hook nil
> +    "Hook run before sending messages."
> +    :type 'hook
> +    :group 'notmuch-send
> +    :group 'notmuch-hooks))

I don't see why this defcustom got indented (viewing context: this diff);
otherwise LGTM.

Tomi


>  
>  (defcustom notmuch-mua-compose-in 'current-window
>    "Where to create the mail buffer used to compose a new message.
> @@ -256,6 +261,8 @@ Typically this is added to `notmuch-mua-send-hook'."
>      ;; Extract the headers of both the reply and the original message.
>      (let* ((original-headers (plist-get original :headers))
>  	   (reply-headers (plist-get reply :reply-headers)))
> +      ;; Run hook here with the original
> +      (run-hook-with-args 'notmuch-mua-reply-functions original)
>        ;; If sender is non-nil, set the From: header to its value.
>        (when sender
>  	(plist-put reply-headers :From sender))
> -- 
> 2.39.2