unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 3/5] test: fix hook-counter to accept the new no-display param
Date: Mon, 03 Sep 2012 14:15:43 +0200	[thread overview]
Message-ID: <xa1t4nnfwbdc.fsf@mina86.com> (raw)
In-Reply-To: <93a480b6dafc48d09b1cfa1a8858cc229025fac9.1346596156.git.jani@nikula.org>

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

Jani Nikula <jani@nikula.org> writes:
> notmuch-hello-refresh-hook is now called with no-display param. Accept
> (and ignore) it in hook-counter.

This should go together with the previous patch since without this
change, previous patch breaks code.

> ---
>  test/test-lib.el |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.el b/test/test-lib.el
> index fa3380c..864780c 100644
> --- a/test/test-lib.el
> +++ b/test/test-lib.el
> @@ -84,7 +84,7 @@ running, quit if it terminated."
>        (kill-emacs)
>      (run-at-time "1 min" nil 'orphan-watchdog pid)))
>  
> -(defun hook-counter (hook)
> +(defun hook-counter (hook &rest no-display)
>    "Count how many times a hook is called.  Increments
>  `hook'-counter variable value if it is bound, otherwise does
>  nothing."
> -- 
> 1.7.9.5
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]

  reply	other threads:[~2012-09-03 12:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-02 14:48 [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc Jani Nikula
2012-09-02 14:48 ` [PATCH v2 1/5] emacs: document the notmuch-hello no-display argument Jani Nikula
2012-09-02 14:48 ` [PATCH v2 2/5] emacs: add no-display arg to notmuch-hello-refresh-hook Jani Nikula
2012-09-07  7:56   ` Tomi Ollila
2012-09-07  8:03     ` Jani Nikula
2012-09-02 14:48 ` [PATCH v2 3/5] test: fix hook-counter to accept the new no-display param Jani Nikula
2012-09-03 12:15   ` Michal Nazarewicz [this message]
2012-09-02 14:48 ` [PATCH v2 4/5] emacs: add notmuch hello refresh hook to display message count change Jani Nikula
2012-09-02 14:48 ` [PATCH v2 5/5] NEWS: notmuch-hello refresh hook changes Jani Nikula
2012-09-02 16:00 ` [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc Tomi Ollila
2012-09-04 17:11 ` Michal Sojka
2012-09-04 20:30   ` Jani Nikula
2012-09-05 21:08     ` Michal Sojka
2012-09-06 15:28       ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1t4nnfwbdc.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).