From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc
Date: Wed, 05 Sep 2012 23:08:11 +0200 [thread overview]
Message-ID: <87zk54yy84.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <877gs9msy8.fsf@nikula.org>
On Tue, Sep 04 2012, Jani Nikula wrote:
> On Tue, 04 Sep 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
>> On Sun, Sep 02 2012, Jani Nikula wrote:
>>> Hi all, v2 of [1] addressing review comments: added NEWS, improved
>>> documentation, made the query customizable.
>>>
>>> [1]
>>> id:"37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org"
>>
>> Hello Jani,
>>
>> if I understand correctly, the goal of this patchset is to display the
>> message with the difference in the number of messages before and after
>> refresh of notmuch-hello.
>
> Difference between two refreshes of notmuch-hello to be specific.
>
>> I think the current implementation is unnecessarily complicated. It
>> would be sufficient to implement this directly in `notmuch-hello'
>> without any hook. If `notmuch-hello-refresh-status-query' is nil
>> (default) no message would be shown. If it is configured to something
>> else, the message would be shown provided that no-display is nil. This
>> way you don't have to break existing user's hooks and achieve the same
>> behavior, don't you?
>
> I think it would be useful to pass no-display to hooks anyway,
> regardless of the use here.
I'm strongly against breaking existing user's setups without a good
reason. The meaning of no-display parameter, as I understand it, is only
to tells whether the refresh should happen in background or foreground.
Isn't there any other method for hooks to check for this conditions? For
example something like checking whether notmuch-hello buffer is shown in
a window of the active frame? Or a simple (perhaps buffer-local)
variable can contain this information.
I don't know what people use notmuch-hello-refresh-hook for. I suppose
that your use case (displaying a message outside of hello buffer) is
rather an exception than a typical use.
> I don't see that as a big reason to do this one way or the other.
> Having this implemented directly in notmuch-hello does not make this
> less complicated either.
That's true, but it would be simpler for users to set it up. With your
patches, users would have to configure the variable (query) as well as
the hook. I propose to have only one place to configure this feature.
-Michal
next prev parent reply other threads:[~2012-09-05 21:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 14:48 [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc Jani Nikula
2012-09-02 14:48 ` [PATCH v2 1/5] emacs: document the notmuch-hello no-display argument Jani Nikula
2012-09-02 14:48 ` [PATCH v2 2/5] emacs: add no-display arg to notmuch-hello-refresh-hook Jani Nikula
2012-09-07 7:56 ` Tomi Ollila
2012-09-07 8:03 ` Jani Nikula
2012-09-02 14:48 ` [PATCH v2 3/5] test: fix hook-counter to accept the new no-display param Jani Nikula
2012-09-03 12:15 ` Michal Nazarewicz
2012-09-02 14:48 ` [PATCH v2 4/5] emacs: add notmuch hello refresh hook to display message count change Jani Nikula
2012-09-02 14:48 ` [PATCH v2 5/5] NEWS: notmuch-hello refresh hook changes Jani Nikula
2012-09-02 16:00 ` [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc Tomi Ollila
2012-09-04 17:11 ` Michal Sojka
2012-09-04 20:30 ` Jani Nikula
2012-09-05 21:08 ` Michal Sojka [this message]
2012-09-06 15:28 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk54yy84.fsf@steelpick.2x.cz \
--to=sojkam1@fel.cvut.cz \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).