unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Matt Armstrong <marmstrong@google.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] doc: sequentialize calls to sphinx-build
Date: Mon, 04 Mar 2019 18:45:41 -0800	[thread overview]
Message-ID: <qf5a7ia3up6.fsf@naz.kir.corp.google.com> (raw)
In-Reply-To: <20190303204018.2544-1-david@tethera.net>

I had never seen this make syntax before so think it might be a bit
mysterious for the next person coming along.  I dug up the reference.
The GNU make info pages call them "order-only" prerequisites.  I might
comment this as:

# Prevent sphinx-build from running in parallel by using "order-only"
# prerequisites.  This avoids races when sphinx-build reads and writes
# cached state.


David Bremner <david@tethera.net> writes:

> In certain conditions the parallel calls to sphinx-build could
> collide, yielding a crash like
>
> Exception occurred:
>   File "/usr/lib/python3/dist-packages/sphinx/environment.py", line 1261, in get_doctree
>     doctree = pickle.load(f)
> EOFError: Ran out of input
> ---
>
> I first observed this on Debian/ppc64le. There it occured about 1 in
> 50 builds. Thanks to Olly Betts for pointing me in the right
> direction.
>
>  doc/Makefile.local | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/doc/Makefile.local b/doc/Makefile.local
> index 16459e35..eed243a0 100644
> --- a/doc/Makefile.local
> +++ b/doc/Makefile.local
> @@ -37,6 +37,13 @@ INFO_INFO_FILES := $(INFO_TEXI_FILES:.texi=.info)
>  %.gz: %
>  	rm -f $@ && gzip --stdout $^ > $@
>  
> +# Sequentialize the calls to sphinx-build to avoid races with
> +# reading/writing state.
> +
> +sphinx-html: | $(DOCBUILDDIR)/.roff.stamp
> +sphinx-texinfo: | sphinx-html
> +sphinx-info: | sphinx-texinfo
> +
>  sphinx-html:
>  	$(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(DOCBUILDDIR)/html
>  
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

      reply	other threads:[~2019-03-05  2:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-03 20:40 [PATCH] doc: sequentialize calls to sphinx-build David Bremner
2019-03-05  2:45 ` Matt Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=qf5a7ia3up6.fsf@naz.kir.corp.google.com \
    --to=marmstrong@google.com \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).