From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <32OJ9XAoKB38pdupvwurqjjrrjoh.frpqrwpxfkqrwpxfkpdlo.ruj@flex--marmstrong.bounces.google.com> Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E54566DE106D for ; Mon, 4 Mar 2019 18:45:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -7.822 X-Spam-Level: X-Spam-Status: No, score=-7.822 tagged_above=-999 required=5 tests=[AWL=-0.122, DKIMWL_WL_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8v4dwaiAKEZy for ; Mon, 4 Mar 2019 18:45:45 -0800 (PST) Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) by arlo.cworth.org (Postfix) with ESMTPS id E9B526DE1069 for ; Mon, 4 Mar 2019 18:45:44 -0800 (PST) Received: by mail-pg1-f201.google.com with SMTP id t6so7035675pgp.10 for ; Mon, 04 Mar 2019 18:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to; bh=NOug3WzO09YrNvyoFY5o4DP9THpFyRmDyZQxf3fCTcw=; b=XLUsTlvbuT1SCdebhwDTidoOn8Nfwr5m81s7RQd+8dWXMxOy2XEGxPqULvIkPWPCHe qcK12dMfMby+p/4cxMtw0sJJu+5nxFv8wZ8w5X9/tEMPcFMhq4I4yRKWyrn8S6gtjcx/ Euj2fug3+LEUu83e17ahNb7JgX7ajsG7mRU8oWOTKk27rrEeTCcsvUjl1LYRT3GKDNc8 61TWyytn4hmKB7qfeeox6pRLfYneKvwzC0lMW/XOWgeJUYgouFiPv4sCId1E8YGgMSut uU3JNfTDqKpCSVGNeSbt05DbvH3umf1JEXI4spuRvO1Axd+zJ8jQXG5CiAaG3lf2l58m FkNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to; bh=NOug3WzO09YrNvyoFY5o4DP9THpFyRmDyZQxf3fCTcw=; b=qilbg5FVFnGo9EmaMkatvhEs4ne9kV55tlFV9Kq8Jl64dJ8WedrOPFoDh6TsYFJnV6 vvKt1vXQgKkvfPjybEM8ZIISpK0nz0FXn9dhJIYLvWI2EVnhrxdM/+KC4YCvLilKfeWB 9aj0d4zEOTndAHiwQN7rR52ZOBux6cHMES/80Lkq/ofxGxAoy0TnSKTOBhmD3Eav8vng BGOdbKQiiTWO2BxmCpgXPABRV3pS71ZdlsKyMACoE3Gtm8VGvB+s1XalcE0YKY3CAH7+ wAMGU8T+GJK/gsF11rzgv60rAjquKk1n+6kCx7OTyrSfOs8bpcg8+Qs1/VH96HHIxg7L ep+w== X-Gm-Message-State: APjAAAVuPkTHp1LK1eJV2a4UJNYUb3mAwJXj2X2ljv05I0kGJbGjOZEM KGm4SNJxDtcU/9YlVMkbCWH0q9Bu9VfCWmXe X-Google-Smtp-Source: APXvYqyzHPbN3NJza3y0jd9LD5VPcVbHKEeZ7KpeUIA0tLAvFkrjhllThiNdpLkIJD6RDgL0QkkrjJADr6N8YluT X-Received: by 2002:a17:902:a9ca:: with SMTP id b10mr7027630plr.115.1551753944469; Mon, 04 Mar 2019 18:45:44 -0800 (PST) Date: Mon, 04 Mar 2019 18:45:41 -0800 In-Reply-To: <20190303204018.2544-1-david@tethera.net> Message-Id: Mime-Version: 1.0 References: <20190303204018.2544-1-david@tethera.net> Subject: Re: [PATCH] doc: sequentialize calls to sphinx-build From: Matt Armstrong To: David Bremner , notmuch@notmuchmail.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 02:45:46 -0000 I had never seen this make syntax before so think it might be a bit mysterious for the next person coming along. I dug up the reference. The GNU make info pages call them "order-only" prerequisites. I might comment this as: # Prevent sphinx-build from running in parallel by using "order-only" # prerequisites. This avoids races when sphinx-build reads and writes # cached state. David Bremner writes: > In certain conditions the parallel calls to sphinx-build could > collide, yielding a crash like > > Exception occurred: > File "/usr/lib/python3/dist-packages/sphinx/environment.py", line 1261, in get_doctree > doctree = pickle.load(f) > EOFError: Ran out of input > --- > > I first observed this on Debian/ppc64le. There it occured about 1 in > 50 builds. Thanks to Olly Betts for pointing me in the right > direction. > > doc/Makefile.local | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/Makefile.local b/doc/Makefile.local > index 16459e35..eed243a0 100644 > --- a/doc/Makefile.local > +++ b/doc/Makefile.local > @@ -37,6 +37,13 @@ INFO_INFO_FILES := $(INFO_TEXI_FILES:.texi=.info) > %.gz: % > rm -f $@ && gzip --stdout $^ > $@ > > +# Sequentialize the calls to sphinx-build to avoid races with > +# reading/writing state. > + > +sphinx-html: | $(DOCBUILDDIR)/.roff.stamp > +sphinx-texinfo: | sphinx-html > +sphinx-info: | sphinx-texinfo > + > sphinx-html: > $(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(DOCBUILDDIR)/html > > -- > 2.20.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch