From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ralph Seichter <abbot@monksofcool.net>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: fix mktemp call for macOS
Date: Fri, 14 Jun 2019 21:11:49 +0300 [thread overview]
Message-ID: <m2wohoavfe.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <m2sgscgido.fsf@guru.guru-group.fi>
On Fri, Jun 14 2019, Tomi Ollila wrote:
> On Fri, Jun 14 2019, Ralph Seichter wrote:
>
>> * David Bremner:
>>
>>> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")
>>>
>>> (borrowed from test/test-lib.sh). This avoids hardcoding the temporary
>>> directory.
>>
>> I had the same thought at first, but I want to ensure that the path
>> length does not cause trouble anymore.
>
> Yes. $TMPDIR could be problematic if it makes the full (unix domain
> socket?) path be too long.
>
> SO, exact version Ralph made looks good to me.
Revert that. mktemp(1) uses $TMPDIR if defined (and just tested)
>
> Tomi
>
>
>>
>> > uname -v
>> Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64
>> > echo $TMPDIR
>> /var/folders/m_/w5lk3r_1495dhnl4l0s96pr00000gn/T/
>>
>> That's my MacBook Pro with macOS 10.14.5 (Mojave). AFAIK, older versions
>> can have longer names. Also, I am concerned with accumulating clutter.
>>
>> > grep clean_tmps_dirs /etc/defaults/periodic.conf
>> daily_clean_tmps_dirs="/tmp"
>>
>> The /tmp directory will, with default settings, be cleaned periodically
>> by the OS, while $TMPDIR (which is user-specific) will not.
>>
>> -Ralph
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2019-06-14 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 0:26 [PATCH] configure: fix mktemp call for macOS Ralph Seichter
2019-06-14 10:57 ` David Bremner
2019-06-14 11:19 ` Ralph Seichter
2019-06-14 17:57 ` Tomi Ollila
2019-06-14 18:11 ` Tomi Ollila [this message]
2019-06-16 14:30 ` Daniel Kahn Gillmor
[not found] <CAC=HcsFwVdsxMeCLk9qZYeHbd_+qJN77EqPZ17S2UgdR0bb6mw@mail.gmail.com>
[not found] ` <5d03ff8e.1c69fb81.c82a3.d08e.GMR@mx.google.com>
2019-06-14 20:16 ` Fwd: Delivery Status Notification (Failure) Tomi Ollila
2019-06-15 17:51 ` [PATCH] configure: fix mktemp call for macOS Ralph Seichter
2019-06-16 11:12 ` Tomi Ollila
2019-06-16 15:18 ` Ralph Seichter
2019-06-17 5:10 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wohoavfe.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=abbot@monksofcool.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).