unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Ralph Seichter <abbot@monksofcool.net>
To: notmuch@notmuchmail.org
Subject: [PATCH] configure: fix mktemp call for macOS
Date: Wed, 12 Jun 2019 02:26:39 +0200	[thread overview]
Message-ID: <87r27z63uk.fsf@ra.horus-it.com> (raw)

The mktemp call in configure is incompatible with /usr/bin/mktemp as
shipped with macOS, where it fails due to a missing parameter. I added
the missing template, and the call is now working with both Apple's
and GNU coreutils' mktemp.

Signed-off-by: Ralph Seichter <abbot@monksofcool.net>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 8b80f0e0..feebafcc 100755
--- a/configure
+++ b/configure
@@ -529,7 +529,7 @@ int main () {
     return 0;
 }
 EOF
-    if ! TEMP_GPG=$(mktemp -d); then
+    if ! TEMP_GPG=$(mktemp -d /tmp/notmuch.XXXXXX); then
         printf 'No.\nCould not make tempdir for testing session-key support.\n'
         errors=$((errors + 1))
     elif ${CC} ${CFLAGS} ${gmime_cflags} _check_session_keys.c ${gmime_ldflags} -o _check_session_keys \
-- 
2.21.0

             reply	other threads:[~2019-06-12  0:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  0:26 Ralph Seichter [this message]
2019-06-14 10:57 ` [PATCH] configure: fix mktemp call for macOS David Bremner
2019-06-14 11:19   ` Ralph Seichter
2019-06-14 17:57     ` Tomi Ollila
2019-06-14 18:11       ` Tomi Ollila
2019-06-16 14:30       ` Daniel Kahn Gillmor
     [not found] <CAC=HcsFwVdsxMeCLk9qZYeHbd_+qJN77EqPZ17S2UgdR0bb6mw@mail.gmail.com>
     [not found] ` <5d03ff8e.1c69fb81.c82a3.d08e.GMR@mx.google.com>
2019-06-14 20:16   ` Fwd: Delivery Status Notification (Failure) Tomi Ollila
2019-06-15 17:51     ` [PATCH] configure: fix mktemp call for macOS Ralph Seichter
2019-06-16 11:12       ` Tomi Ollila
2019-06-16 15:18         ` Ralph Seichter
2019-06-17  5:10           ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r27z63uk.fsf@ra.horus-it.com \
    --to=abbot@monksofcool.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).