From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/3] Use global keymap for pick entry.
Date: Mon, 16 Sep 2013 23:31:25 +0300 [thread overview]
Message-ID: <m2vc20cxuq.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com>
On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:
> This uses the recently added global keymap for pick entry. Adding this
> showed a couple of historical anomalies: first that we don't need to
> quote the keymap in define-key, and secondly that the
> notmuch-pick-from-hello function is no longer needed.
>
> Thus we remove the superfluous quotes and we remove the unneeded
> function.
>
> All tests pass and all key bindings still seem to work.
This series LGTM. I don't fully understand this (fset 'kmap kmap)
business but everywhere I looked (define-key uses the non-symbol-reference
to the keymap (were there fsets or not))
>
> Best wishes
>
> Mark
Tomi
>
>
> Mark Walters (3):
> contrib: pick: remove some superfluous quotes
> contrib: pick: use the new notmuch-common-keymap for pick entry
> contrib: pick: remove unused notmuch-pick-from-hello
>
> contrib/notmuch-pick/notmuch-pick.el | 21 ++++-----------------
> 1 files changed, 4 insertions(+), 17 deletions(-)
>
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-09-16 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 14:35 [PATCH 0/3] Use global keymap for pick entry Mark Walters
2013-09-15 14:35 ` [PATCH 1/3] contrib: pick: remove some superfluous quotes Mark Walters
2013-09-15 14:35 ` [PATCH 2/3] contrib: pick: use the new notmuch-common-keymap for pick entry Mark Walters
2013-09-15 14:35 ` [PATCH 3/3] contrib: pick: remove unused notmuch-pick-from-hello Mark Walters
2013-09-16 20:31 ` Tomi Ollila [this message]
2013-09-23 10:39 ` [PATCH 0/3] Use global keymap for pick entry David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vc20cxuq.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).