From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 3/3] contrib: pick: remove unused notmuch-pick-from-hello
Date: Sun, 15 Sep 2013 15:35:06 +0100 [thread overview]
Message-ID: <1379255706-2418-4-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com>
This function was used for pick entry from hello but isn't needed
anymore. It was modelled on notmuch-hello-search which is now only
used non-interactively (and notmuch-pick does now add to the
recent-search history correctly).
---
contrib/notmuch-pick/notmuch-pick.el | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 386fef5..69bea2a 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -428,17 +428,6 @@ Does NOT change the database."
(notmuch-pick-close-message-window)
(notmuch-pick query)))
-;; This function should be in notmuch-hello.el but we are trying to
-;; minimise impact on the rest of the codebase.
-(defun notmuch-pick-from-hello (&optional search)
- "Run a query and display results in experimental notmuch-pick mode"
- (interactive)
- (unless (null search)
- (setq search (notmuch-hello-trim search))
- (let ((history-delete-duplicates t))
- (add-to-history 'notmuch-search-history search)))
- (notmuch-pick search))
-
;; This function should be in notmuch-show.el but be we trying to
;; minimise impact on the rest of the codebase.
(defun notmuch-pick-from-show-current-query ()
--
1.7.9.1
next prev parent reply other threads:[~2013-09-15 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 14:35 [PATCH 0/3] Use global keymap for pick entry Mark Walters
2013-09-15 14:35 ` [PATCH 1/3] contrib: pick: remove some superfluous quotes Mark Walters
2013-09-15 14:35 ` [PATCH 2/3] contrib: pick: use the new notmuch-common-keymap for pick entry Mark Walters
2013-09-15 14:35 ` Mark Walters [this message]
2013-09-16 20:31 ` [PATCH 0/3] Use global keymap " Tomi Ollila
2013-09-23 10:39 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379255706-2418-4-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).