From: Tomi Ollila <tomi.ollila@iki.fi>
To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org
Cc: Vladimir Marek <vlmarek@volny.cz>
Subject: Re: [PATCH 2/4] dirent->d_type not available on Soalris
Date: Wed, 11 Apr 2012 21:57:45 +0300 [thread overview]
Message-ID: <m2ty0qm6za.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1333989127-21523-1-git-send-email-Vladimir.Marek@oracle.com>
On Mon, Apr 09 2012, Vladimir.Marek@oracle.com wrote:
> From: Vladimir Marek <vlmarek@volny.cz>
>
> The inspiration was taken from similar issue in mutt:
> http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html
>
> Signed-off-by: Vladimir Marek <vlmarek@volny.cz>
> ---
Code looks pretty good, but 2 issues
1) Commit message should contain more verbose information what and
why something was done.
2) Does these #ifdefs break code indenters such as uncrustify(1),
indent(1) and emacs(1) indent functionality.
(That used to happen but maybe these indenters are smarted today.
Tomi
> notmuch-new.c | 28 ++++++++++++++++++++++++++++
> 1 files changed, 28 insertions(+), 0 deletions(-)
next prev parent reply other threads:[~2012-04-11 18:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 10:17 notmuch on Solaris Vladimir.Marek
2012-04-09 10:17 ` [PATCH 1/4] Make configure use /bin/bash instead of /bin/sh Vladimir.Marek
2012-04-09 11:10 ` Jani Nikula
2012-04-09 12:19 ` Vladimir Marek
2012-04-10 17:26 ` Tomi Ollila
2012-04-11 8:43 ` Vladimir Marek
2012-04-11 18:47 ` Tomi Ollila
2012-04-30 11:58 ` David Bremner
2012-04-30 12:09 ` Tomi Ollila
2012-04-09 10:17 ` [PATCH 2/4] dirent->d_type not available on Soalris Vladimir.Marek
2012-04-09 11:17 ` Jani Nikula
2012-04-09 15:12 ` Vladimir Marek
2012-04-09 15:46 ` Adam Wolfe Gordon
2012-04-09 16:32 ` Vladimir.Marek
2012-04-11 18:57 ` Tomi Ollila [this message]
2012-04-11 19:36 ` Austin Clements
2012-04-09 10:17 ` [PATCH 3/4] Private strsep implementation Vladimir.Marek
2012-10-15 5:05 ` Ethan Glasser-Camp
2012-04-09 10:17 ` [PATCH 4/4] Explicitly type void* pointers Vladimir.Marek
2012-04-09 11:04 ` Jani Nikula
2012-04-09 18:15 ` Vladimir Marek
2012-04-09 21:31 ` Jani Nikula
2012-04-10 6:53 ` Vladimir Marek
2012-04-11 21:11 ` Austin Clements
2012-04-12 8:02 ` Jani Nikula
2012-04-12 17:57 ` Austin Clements
2012-04-15 21:05 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ty0qm6za.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=Vladimir.Marek@oracle.com \
--cc=notmuch@notmuchmail.org \
--cc=vlmarek@volny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).