From: Jani Nikula <jani@nikula.org>
To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org
Cc: Vladimir Marek <vlmarek@volny.cz>
Subject: Re: [PATCH 4/4] Explicitly type void* pointers
Date: Mon, 16 Apr 2012 00:05:58 +0300 [thread overview]
Message-ID: <87lilwk8nd.fsf@nikula.org> (raw)
In-Reply-To: <1333966665-10469-5-git-send-email-Vladimir.Marek@oracle.com>
I tagged this patch notmuch::obsolete (see [1]) as the template
workaround was pushed to master (commit
de0557477d908be26615e8fda9f5eb62bed68b65).
Jani.
[1] http://nmbug.tethera.net/status/
On Mon, 09 Apr 2012, Vladimir.Marek@oracle.com wrote:
> From: Vladimir Marek <vlmarek@volny.cz>
>
>
> Signed-off-by: Vladimir Marek <vlmarek@volny.cz>
> ---
> lib/database.cc | 2 +-
> lib/message.cc | 2 +-
> lib/thread.cc | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/database.cc b/lib/database.cc
> index 16c4354..3c82632 100644
> --- a/lib/database.cc
> +++ b/lib/database.cc
> @@ -1361,7 +1361,7 @@ _resolve_message_id_to_thread_id (notmuch_database_t *notmuch,
> return status;
>
> if (message) {
> - *thread_id_ret = talloc_steal (ctx,
> + *thread_id_ret = (const char*)talloc_steal (ctx,
> notmuch_message_get_thread_id (message));
>
> notmuch_message_destroy (message);
> diff --git a/lib/message.cc b/lib/message.cc
> index 0075425..d56d442 100644
> --- a/lib/message.cc
> +++ b/lib/message.cc
> @@ -220,7 +220,7 @@ _notmuch_message_create_for_message_id (notmuch_database_t *notmuch,
> message_id,
> &message);
> if (message)
> - return talloc_steal (notmuch, message);
> + return (notmuch_message_t*) talloc_steal (notmuch, message);
> else if (*status_ret)
> return NULL;
>
> diff --git a/lib/thread.cc b/lib/thread.cc
> index e976d64..d41ff3e 100644
> --- a/lib/thread.cc
> +++ b/lib/thread.cc
> @@ -225,7 +225,7 @@ _thread_add_message (notmuch_thread_t *thread,
> char *clean_author;
>
> _notmuch_message_list_add_message (thread->message_list,
> - talloc_steal (thread, message));
> + (_notmuch_message*)talloc_steal (thread, message));
> thread->total_messages++;
>
> g_hash_table_insert (thread->message_hash,
> --
> 1.7.3.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
prev parent reply other threads:[~2012-04-15 21:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 10:17 notmuch on Solaris Vladimir.Marek
2012-04-09 10:17 ` [PATCH 1/4] Make configure use /bin/bash instead of /bin/sh Vladimir.Marek
2012-04-09 11:10 ` Jani Nikula
2012-04-09 12:19 ` Vladimir Marek
2012-04-10 17:26 ` Tomi Ollila
2012-04-11 8:43 ` Vladimir Marek
2012-04-11 18:47 ` Tomi Ollila
2012-04-30 11:58 ` David Bremner
2012-04-30 12:09 ` Tomi Ollila
2012-04-09 10:17 ` [PATCH 2/4] dirent->d_type not available on Soalris Vladimir.Marek
2012-04-09 11:17 ` Jani Nikula
2012-04-09 15:12 ` Vladimir Marek
2012-04-09 15:46 ` Adam Wolfe Gordon
2012-04-09 16:32 ` Vladimir.Marek
2012-04-11 18:57 ` Tomi Ollila
2012-04-11 19:36 ` Austin Clements
2012-04-09 10:17 ` [PATCH 3/4] Private strsep implementation Vladimir.Marek
2012-10-15 5:05 ` Ethan Glasser-Camp
2012-04-09 10:17 ` [PATCH 4/4] Explicitly type void* pointers Vladimir.Marek
2012-04-09 11:04 ` Jani Nikula
2012-04-09 18:15 ` Vladimir Marek
2012-04-09 21:31 ` Jani Nikula
2012-04-10 6:53 ` Vladimir Marek
2012-04-11 21:11 ` Austin Clements
2012-04-12 8:02 ` Jani Nikula
2012-04-12 17:57 ` Austin Clements
2012-04-15 21:05 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lilwk8nd.fsf@nikula.org \
--to=jani@nikula.org \
--cc=Vladimir.Marek@oracle.com \
--cc=notmuch@notmuchmail.org \
--cc=vlmarek@volny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).