[PATCH] notmuch-mutt: Using /usr/bin/env to call perl

[PATCH] notmuch-mutt: Using /usr/bin/env to call perl

[Taylor Carpenter]

Supports other perl install locations
---
 contrib/notmuch-mutt/notmuch-mutt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt
index 71206c3..424f9a3 100755
--- a/contrib/notmuch-mutt/notmuch-mutt
+++ b/contrib/notmuch-mutt/notmuch-mutt
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl -w
 #
 # notmuch-mutt - notmuch (of a) helper for Mutt
 #
-- 
1.7.7.4

Re: [PATCH] notmuch-mutt: Using /usr/bin/env to call perl

[Tomi Ollila]

On Thu, Apr 12 2012, Taylor Carpenter <taylor@codecafe.com> wrote:

> Supports other perl install locations
> ---
>  contrib/notmuch-mutt/notmuch-mutt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt
> index 71206c3..424f9a3 100755
> --- a/contrib/notmuch-mutt/notmuch-mutt
> +++ b/contrib/notmuch-mutt/notmuch-mutt
> @@ -1,4 +1,4 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl -w
>  #
>  # notmuch-mutt - notmuch (of a) helper for Mutt
>  #

shebang lines supports only one arg to the command
-- multiple may confuse things. I tried following:

$ echo '#!/usr/bin/env perl -w' > foo.pl
$ chmod 755 foo.pl
$ ./foo.pl 
/usr/bin/env: perl -w: No such file or directory
zsh: exit 127   ./foo.pl

I.e. drop the -w from command line. use warnings;
(which is already in the code) is enough in this case.

Tomi