Re: [PATCH 0/2] emacs: Fold long headers when sending

[Tomi Ollila <tomi.ollila@iki.fi>]

On Sun, Jan 29 2017, Mark Walters <markwalters1009@gmail.com> wrote:

> This pair of patches add a test for folding long headers, and backport
> the bugfix from emacs master. This fixes the bug reported in
> id:87612qwh04.fsf@viking.dsc.soic.indiana.edu
>
> The fix in emacs master (77bbca8c82f6e553c42abbfafca28f55fc995d00)
> runs the folding function just before message-header-hook, so this fix
> should give almost exactly the same behaviour.
>
> Since message--fold-long-headers was introduced in the same commit
> this should mean we do not apply the fix for any version of emacs
> which it already has it.
>
> I don't know whether my bash in the test suite is sufficiently
> portable, so if anyone who knows about that could check I would be
> grateful. (For example, is seq -s " " 1 1000 standard?)

`seq` is not standard, but these days it seems to exist on freebsd and
macos (but may not on solaris). however, in bash one can do
 
long_subject="This is a long subject `echo {1..1000}`"

(to expand {1..1000} inside "" one need to "execute" it -- a trick like
set_long_subject () { long_subject="This is a long subject $*"; }
set_long_subject {1..1000} ;: is unecessarily "complex" for this ;/


Tomi

PS: fwiw with `echo` (shell-builtin) there just one fork(2) is executed;
using `seq` 2 fork(2)s and one execve(2) would be executed (since bash).


>
> Best wishes
>
> Mark
>
>
>
> Mark Walters (2):
>   Test: emacs: test for folding long headers.
>   emacs: compat: backport fix for folding long headers when sending
>
>  emacs/notmuch-compat.el | 28 +++++++++++++++---
>  test/T310-emacs.sh      | 78 +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 102 insertions(+), 4 deletions(-)
>
> -- 
> 2.1.4