From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E86886DE0A9A for ; Mon, 30 Jan 2017 08:20:36 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.508 X-Spam-Level: X-Spam-Status: No, score=0.508 tagged_above=-999 required=5 tests=[AWL=-0.144, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M1jagJHJYn-o for ; Mon, 30 Jan 2017 08:20:35 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 55EDC6DE0159 for ; Mon, 30 Jan 2017 08:20:34 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 550D010004A for ; Mon, 30 Jan 2017 18:19:56 +0200 (EET) From: Tomi Ollila To: notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] emacs: Fold long headers when sending In-Reply-To: <1485684281-2760-1-git-send-email-markwalters1009@gmail.com> References: <1485684281-2760-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.23.3+85~g2b85e66 (https://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 16:20:37 -0000 On Sun, Jan 29 2017, Mark Walters wrote: > This pair of patches add a test for folding long headers, and backport > the bugfix from emacs master. This fixes the bug reported in > id:87612qwh04.fsf@viking.dsc.soic.indiana.edu > > The fix in emacs master (77bbca8c82f6e553c42abbfafca28f55fc995d00) > runs the folding function just before message-header-hook, so this fix > should give almost exactly the same behaviour. > > Since message--fold-long-headers was introduced in the same commit > this should mean we do not apply the fix for any version of emacs > which it already has it. > > I don't know whether my bash in the test suite is sufficiently > portable, so if anyone who knows about that could check I would be > grateful. (For example, is seq -s " " 1 1000 standard?) `seq` is not standard, but these days it seems to exist on freebsd and macos (but may not on solaris). however, in bash one can do long_subject="This is a long subject `echo {1..1000}`" (to expand {1..1000} inside "" one need to "execute" it -- a trick like set_long_subject () { long_subject="This is a long subject $*"; } set_long_subject {1..1000} ;: is unecessarily "complex" for this ;/ Tomi PS: fwiw with `echo` (shell-builtin) there just one fork(2) is executed; using `seq` 2 fork(2)s and one execve(2) would be executed (since bash). > > Best wishes > > Mark > > > > Mark Walters (2): > Test: emacs: test for folding long headers. > emacs: compat: backport fix for folding long headers when sending > > emacs/notmuch-compat.el | 28 +++++++++++++++--- > test/T310-emacs.sh | 78 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 102 insertions(+), 4 deletions(-) > > -- > 2.1.4