From: Tomi Ollila <tomi.ollila@iki.fi>
To: Anton Khirnov <anton@khirnov.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query
Date: Thu, 11 Jun 2020 00:02:53 +0300 [thread overview]
Message-ID: <m2pna6ws5e.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <159004491093.29502.10419450764412120360@lain.red.khirnov.net>
Hi Anton,
On Thu, May 21 2020, Anton Khirnov wrote:
> ping
Great (an important) stuff in this series !
...just that...
Floris did good review on your changes the next day.
What I remember was there (looked 30 mins ago)
- style: somewhat important (I press more there). Easy to get better,
good and consistent style makes it better
- docs in code: like Floris mentioned, the docs in commit messages are
are not seen by user. The relevant documentation is
to be with the code. commit message tells what was done
and why
- tests: since pytest is used to test the current notmuch2 cffi python
tests, all new code that can be tested pytest code to do so
is to be added
And these have to be done now -- postponing such a things into future
will just mean that it never happens, and the messines and entropy of
the notmuch code gets even greater in such a case...
>
> --
> Anton Khirnov
Tomi
next prev parent reply other threads:[~2020-06-10 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 5:05 [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query Anton Khirnov
2020-05-09 5:05 ` [PATCH 2/2] python/notmuch2: add bindings for the database config strings Anton Khirnov
2020-05-21 22:45 ` Floris Bruynooghe
2020-05-21 7:08 ` [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query Anton Khirnov
2020-05-21 11:13 ` David Bremner
2020-06-10 21:02 ` Tomi Ollila [this message]
2020-06-13 12:38 ` [PATCH] wip test for id:20200509050526.23148-1-anton@khirnov.net David Bremner
2020-05-21 22:17 ` [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query Floris Bruynooghe
-- strict thread matches above, loose matches on Subject: below --
2020-06-15 20:58 python: Continuing message re-use fix Floris Bruynooghe
2020-06-15 20:58 ` [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query Floris Bruynooghe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pna6ws5e.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=anton@khirnov.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).