From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wBvnBZFK4V6bSgAA0tVLHw (envelope-from ) for ; Wed, 10 Jun 2020 21:03:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4CyhAZFK4V5ZSAAAbx9fmQ (envelope-from ) for ; Wed, 10 Jun 2020 21:03:13 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7FCE39400D3 for ; Wed, 10 Jun 2020 21:03:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 111606DE0F7F; Wed, 10 Jun 2020 14:03:07 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C_k2N5ajJOvQ; Wed, 10 Jun 2020 14:03:06 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id C39496DE1050; Wed, 10 Jun 2020 14:03:05 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 8204B6DE1050 for ; Wed, 10 Jun 2020 14:03:04 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m-xLqjmuI897 for ; Wed, 10 Jun 2020 14:03:02 -0700 (PDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by arlo.cworth.org (Postfix) with ESMTPS id 970F76DE0F7F for ; Wed, 10 Jun 2020 14:03:00 -0700 (PDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 269E31B00082; Thu, 11 Jun 2020 00:02:56 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1591822976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qe45eyJ7AA3KTdhuLJ+LbRzYOxu51adpCWwPCq69Li4=; b=o5Wu3HDwlGoWvQlkFiIxi0QqVt38+4dhmebHtsAnOcvPZ5emfGvB2lfpurkUR1TypuIZrU vHeAnUk11ja4c50Vzq046fvffaeVun/1iIeX/KlwYOOcNHkRVhSvUAa3qoDkJDrBnBpC7G qijWcgo0wkOqsU7RBGYVraH/BRLKQb1U5sLPryMh/iHkPSCqPJovokMQBgtSpfni/GwDAP LFk0h8sXIzwysDLv3KXL7hJoXuxs2akSmafra48fP83b7B/ZJZWOzpdP+Yis2ctcdB/wtL 1nESuVY3Ty7zc3lwW6/1uU1PSqyfbE+fzxS7j5tun22la1zhTCaIg4wYTp747w== From: Tomi Ollila To: Anton Khirnov , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query In-Reply-To: <159004491093.29502.10419450764412120360@lain.red.khirnov.net> References: <20200509050526.23148-1-anton@khirnov.net> <159004491093.29502.10419450764412120360@lain.red.khirnov.net> User-Agent: Notmuch/0.30~rc1+2~ga8fcf97 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1591822976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qe45eyJ7AA3KTdhuLJ+LbRzYOxu51adpCWwPCq69Li4=; b=oPmc7Djr/4XLymW3u9nVvIPeNFh07Z0G+MWVmhY/+clJMsPN9gN5tVDdl2lg8JIDO7rR4o b9Dm1q9mdy1gPyYpt6syuUAG+eoLO9JzOTo6U93E/LW02VfrHRkPMsX0xVM+Hp+kjhwRLC z83islAVJ1PpM5Apb5mnaLcktgQ3hSFjUeV91kFOtizfXzD2eArTv4QS6q3I9obfF2xP8F XsJnIvlaPz4IeeT9d9lhxk2hG6JU9TAPPyCW72Y5qfgx/d83k0lQZ8pGG48Gnekl/fH+PD kJEoK/wI0ax2F+rzvABIw3+oH/ZN4urJX9/pjsHKIHGTffZv/F8+0Cbrli+SKw== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1591822976; a=rsa-sha256; cv=none; b=H0xN3AiGXqYifQ1YVTYtpvYYCgvphZfIveAb6fNAt6KfAc9Xj67YfW4zKU02/JwtbrtWvO OAXvYdyrHEVicRdC3hHw17zHV3b5p7fX7PPGLxjS9W3h/DZFBBEkFbbI5IrExGHtUmXfKH hmtAlaURPkoWvWzTkRBZK/DxHd1Wtt2pwG2T8HFEt0FfNrsE5LYlF4Q2x23UgW047hljj5 udoK3Bni/e9cb9XmE6t3wARPhCQHSJcG6hlIT328JAKj4O7DHbFLenB43UAyXZIAZ/8OiK 7TrUOh73K+Xh/+BG+O2IHTq+Tf/L2N2sw+6D+D3Bn09DrInTh3RvIedSdGB+lQ== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=o5Wu3HDw; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 3.49 X-TUID: dRhtOSppbu1N Hi Anton, On Thu, May 21 2020, Anton Khirnov wrote: > ping Great (an important) stuff in this series ! ...just that... Floris did good review on your changes the next day. What I remember was there (looked 30 mins ago) - style: somewhat important (I press more there). Easy to get better, good and consistent style makes it better - docs in code: like Floris mentioned, the docs in commit messages are are not seen by user. The relevant documentation is to be with the code. commit message tells what was done and why - tests: since pytest is used to test the current notmuch2 cffi python tests, all new code that can be tested pytest code to do so is to be added And these have to be done now -- postponing such a things into future will just mean that it never happens, and the messines and entropy of the notmuch code gets even greater in such a case... > > -- > Anton Khirnov Tomi