(no subject)

(no subject)

[Bart Trojanowski]

Hi,

I find this patch useful for searching my mail.  I realize that the
option is horrendously long, and I would take any suggestions to shorten
it or to use a short op, like -m.

-Bart

(no subject)

[david]

Thanks to Micah Anderson on IRC for pointing out that the previous
version of this patch broke '?' in notmuch-show mode.  This was
arguably a bug in the notmuch help code, fixed in patch 2 of the
series.  I wouldn't be surprised if 'map-keymap' could be used other
places in the code, but I kept things minimal-ish.  The first patch 
has been revised to actually include documentation strings (blush).

(no subject)

[Ingmar Vanhassel]

I was just going to mail an updated series for this. I'd definitely like to see
this upstream.

I amended the first patch to install the notmuch.h header.

The second patch from a friend of mine fixes a parallel make issue I ran into
when I tested one of your intiial patches. I ran this patch by you ages on
#notmuch, not sure why it isn't included, not sure why you didn't included it?

The third patch adds a way to configure where to install libraries.
On Exherbo x86_64 we install 64 bit libraries to /usr/lib64/ so I need a switch
to configure this.

Regards,
Ingmar

(no subject)

[Ingmar Vanhassel]

I'd very much like to see this upstream.

Here's my updated series for this.

I amended your first patch to make it install the notmuch.h header too.

The second patch fixed some parallel make issue I had while testing your series. We discussed this
ages ago on #notmuch, I don't remember the details at the moment, and I can't check my logs right
now. Any reason why this isn't included in your current patch?

The third patch adds a configure switch to configure where to install libraries. It has one issue
I'm aware off. Setting --prefix=/usr without setting --libdir does the wrong thing. This should
probably be fixed, but I don't have any immediate ideas how to do this.

So, series tested by me and Michael Forney, and I'm using it for my notmuch, please apply. :)

Re: (no subject)

[Sebastian Spaeth]

On Fri, 12 Mar 2010 14:47:33 +0100, Ingmar Vanhassel <ingmar@exherbo.org> wrote:
> Here's my updated series for this.

Ben Gamaris original patch gives me an "-lnotmuch" not found failure
during compilation.
Your patchset compiles fine and installs /usr/local/bin/notmuch and
/usr/local/lib/libnotmuch.so.1. However, it doesn't find it when running
and exits saying libnotmuch.so not found.

I don't know anything about LD_LIBRARY_PATH and friends, but using the
default Makefile options (which use /usr/local as prefix) a standard
install should still work :-).

Looking eagerly forward to a shared notmuch library.

spaetz

Re: (no subject)

[ingmar]

> Ben Gamaris original patch gives me an "-lnotmuch" not found failure
> during compilation.
> Your patchset compiles fine and installs /usr/local/bin/notmuch and
> /usr/local/lib/libnotmuch.so.1. However, it doesn't find it when running
> and exits saying libnotmuch.so not found.

Right, that was the error the second patch fixes. Sorry, honestly couldn't
remember, thanks for testing!

> I don't know anything about LD_LIBRARY_PATH and friends, but using the
> default Makefile options (which use /usr/local as prefix) a standard
> install should still work :-).

What's the value of LDPATH in your environment? It should contain /usr/local/lib.
If it doesn't that's not an issue with the patch, but with your installation/distro
afaik.

Re: (no subject)

[Sebastian Spaeth]

On Fri, 12 Mar 2010 15:43:10 +0000, ingmar@exherbo.org wrote:
> What's the value of LDPATH in your environment? It should contain /usr/local/lib.
> If it doesn't that's not an issue with the patch, but with your installation/distro

ubuntu 9.10 and I don't have LDPATH set at all. Thanks, I will try to
fix that.

Sebastian

Re: (no subject)

[ingmar]

> ubuntu 9.10 and I don't have LDPATH set at all. Thanks, I will try to
> fix that.

Oh, nevermind what I said earlier.

Verify that  /usr/local/lib is in /etc/ld.so.conf. If not add it there. Then run ldconfig
after installing notmuch, then it should work. Doing everything with the package manager makes
you forget the basics.

Regards,
Ingmar

Re: (no subject)

[Sebastian Spaeth]

On Fri, 12 Mar 2010 16:02:03 +0100, "Sebastian Spaeth" <Sebastian@SSpaeth.de> wrote:
> On Fri, 12 Mar 2010 14:47:33 +0100, Ingmar Vanhassel <ingmar@exherbo.org> wrote:
> Your patchset compiles fine and installs /usr/local/bin/notmuch and
> /usr/local/lib/libnotmuch.so.1. However, it doesn't find it when running
> and exits saying libnotmuch.so not found.

DOH, a simple "sudo ldconfig" fixed the issue on a stock Ubuntu on my
box. Your patch series works fine.



I just tested the shared lib by creating a small python binding to libnotmuch
which can be found here: http://bitbucket.org/spaetz/cnotmuch
(It basically does not bind many things yet :-), but it demos that it
works in general).

This is my sample session:
>>>from cnotmuch import notmuch
>>>db = notmuch.Database()
>>>db.get_path()
'/home/spaetz/mail'
>>>tags = db.get_all_tags()
inited tags with 44762960 'Notmuch DB /home/spaetz/mail'
>>>for tag in tags: 
>>>  print tag
inbox
...
maildir::draft
Freeing the Tags now

#---------------------------------------------

>>>db = notmuch.Database("/home/spaetz/mailHAHA")
NotmuchError: Could not open the specified database

#---------------------------------------------

>>>tags = notmuch.Database("/home/spaetz/mail").get_all_tags()
>>>del(tags)
Freeing the Tags now
Freeing the database now

Re: (no subject)

[Sebastian Spaeth]

On Fri, 12 Mar 2010 18:46:02 +0000, ingmar@exherbo.org wrote:
> > ubuntu 9.10 and I don't have LDPATH set at all. Thanks, I will try to
> > fix that.
> 
> Oh, nevermind what I said earlier.
> 
> Verify that  /usr/local/lib is in /etc/ld.so.conf. If not add it there. Then run ldconfig
> after installing notmuch, then it should work. Doing everything with the package manager makes
> you forget the basics.

As, I just said in a different reply. Running "sudo ldconfig" fixed it on
a stock Ubuntu system.

Re: (no subject)

[Ben Gamari]

On Fri, 12 Mar 2010 14:41:22 +0100, Ingmar Vanhassel <ingmar@exherbo.org> wrote:
> I was just going to mail an updated series for this. I'd definitely like to see
> this upstream.
> 
I agree. It would be quite nice to finally have to this merged.

> I amended the first patch to install the notmuch.h header.
> 
> The second patch from a friend of mine fixes a parallel make issue I ran into
> when I tested one of your intiial patches. I ran this patch by you ages on
> #notmuch, not sure why it isn't included, not sure why you didn't included it?

Oops, I guess I lost track of it. My bad, things have been pretty scattered in
my world recently. Either way, it looks like you have the shared library thing
covered with this patch set. It is definitely much more refined than mine. I'd
definitely be in favor of this going in. Thanks for your work.

- Ben

[PATCH] emacs: do not modify subject in search or show

[Jameson Graef Rollins]

A previous patch [0] replaced blank subject lines with '[No Subject]'
in search and show mode.  Apparently this was needed to circumvent
some bug in the printing code, but there was no need for it search or
show, and it is definitely not desirable, so we undo it here (a revert
is no longer feasible).  We should not be modifying strings in the
original message without good reason, or without a clear indication
that we are doing so, neither of which apply in this case.  For
further discussion see [0].

[0] id:"1327918561-16245-3-git-send-email-dme@dme.org"
---
 emacs/notmuch-print.el |    4 ++--
 emacs/notmuch-show.el  |    5 +----
 emacs/notmuch.el       |    5 ++---
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
index 6653d97..81b2ef0 100644
--- a/emacs/notmuch-print.el
+++ b/emacs/notmuch-print.el
@@ -60,7 +60,7 @@ Optional OUTPUT allows passing a list of flags to muttprint."
 
 (defun notmuch-print-ps-print (msg)
   "Print a message buffer using the ps-print package."
-  (let ((subject (notmuch-prettify-subject
+  (let ((subject (notmuch-print-prettify-subject
 		  (plist-get (notmuch-show-get-prop :headers msg) :Subject))))
     (rename-buffer subject t)
     (ps-print-buffer)))
@@ -68,7 +68,7 @@ Optional OUTPUT allows passing a list of flags to muttprint."
 (defun notmuch-print-ps-print/evince (msg)
   "Preview a message buffer using ps-print and evince."
   (let ((ps-file (make-temp-file "notmuch"))
-	(subject (notmuch-prettify-subject
+	(subject (notmuch-print-prettify-subject
 		  (plist-get (notmuch-show-get-prop :headers msg) :Subject))))
     (rename-buffer subject t)
     (ps-print-buffer ps-file)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 30b26d1..1e55099 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1075,7 +1075,7 @@ function is used."
       (run-hooks 'notmuch-show-hook))
 
     ;; Set the header line to the subject of the first message.
-    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-pretty-subject)))))
+    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-subject)))))
 
 (defun notmuch-show-capture-state ()
   "Capture the state of the current buffer.
@@ -1375,9 +1375,6 @@ current thread."
 (defun notmuch-show-get-depth ()
   (notmuch-show-get-prop :depth))
 
-(defun notmuch-show-get-pretty-subject ()
-  (notmuch-prettify-subject (notmuch-show-get-subject)))
-
 (defun notmuch-show-set-tags (tags)
   "Set the tags of the current message."
   (notmuch-show-set-prop :tags tags)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index ba833e6..326645d 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -507,7 +507,7 @@ Complete list of currently available key bindings:
   "Display the currently selected thread."
   (interactive)
   (let ((thread-id (notmuch-search-find-thread-id))
-	(subject (notmuch-prettify-subject (notmuch-search-find-subject))))
+	(subject (notmuch-search-find-subject)))
     (if (> (length thread-id) 0)
 	(notmuch-show thread-id
 		      (current-buffer)
@@ -877,8 +877,7 @@ non-authors is found, assume that all of the authors match."
 		      ;; We currently just throw away excluded matches.
 		      (unless (eq (aref count 1) ?0)
 			(let ((beg (point)))
-			  (notmuch-search-show-result date count authors
-						      (notmuch-prettify-subject subject) tags)
+			  (notmuch-search-show-result date count authors subject tags)
 			  (notmuch-search-color-line beg (point) tag-list)
 			  (put-text-property beg (point) 'notmuch-search-thread-id thread-id)
 			  (put-text-property beg (point) 'notmuch-search-authors authors)
-- 
1.7.9.5

[PATCH v2] emacs: do not modify subject in search or show

[Jameson Graef Rollins]

A previous patch [0] replaced blank subject lines with '[No Subject]'
in search and show mode.  Apparently this was needed to circumvent
some bug in the printing code, but there was no need for it search or
show, and it is definitely not desirable, so we undo it here (a revert
is no longer feasible).  We should not be modifying strings in the
original message without good reason, or without a clear indication
that we are doing so, neither of which apply in this case.  For
further discussion see [0].

[0] id:"1327918561-16245-3-git-send-email-dme@dme.org"
---
Sorry, there was a small bug in the previous version (notmuch-print.el
was mistakenly modified).

 emacs/notmuch-show.el |    5 +----
 emacs/notmuch.el      |    5 ++---
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 30b26d1..1e55099 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1075,7 +1075,7 @@ function is used."
       (run-hooks 'notmuch-show-hook))
 
     ;; Set the header line to the subject of the first message.
-    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-pretty-subject)))))
+    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-subject)))))
 
 (defun notmuch-show-capture-state ()
   "Capture the state of the current buffer.
@@ -1375,9 +1375,6 @@ current thread."
 (defun notmuch-show-get-depth ()
   (notmuch-show-get-prop :depth))
 
-(defun notmuch-show-get-pretty-subject ()
-  (notmuch-prettify-subject (notmuch-show-get-subject)))
-
 (defun notmuch-show-set-tags (tags)
   "Set the tags of the current message."
   (notmuch-show-set-prop :tags tags)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index ba833e6..326645d 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -507,7 +507,7 @@ Complete list of currently available key bindings:
   "Display the currently selected thread."
   (interactive)
   (let ((thread-id (notmuch-search-find-thread-id))
-	(subject (notmuch-prettify-subject (notmuch-search-find-subject))))
+	(subject (notmuch-search-find-subject)))
     (if (> (length thread-id) 0)
 	(notmuch-show thread-id
 		      (current-buffer)
@@ -877,8 +877,7 @@ non-authors is found, assume that all of the authors match."
 		      ;; We currently just throw away excluded matches.
 		      (unless (eq (aref count 1) ?0)
 			(let ((beg (point)))
-			  (notmuch-search-show-result date count authors
-						      (notmuch-prettify-subject subject) tags)
+			  (notmuch-search-show-result date count authors subject tags)
 			  (notmuch-search-color-line beg (point) tag-list)
 			  (put-text-property beg (point) 'notmuch-search-thread-id thread-id)
 			  (put-text-property beg (point) 'notmuch-search-authors authors)
-- 
1.7.9.5

[No Subject]

[Tomi Ollila]

On Sun, Apr 15 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:

> A previous patch [0] replaced blank subject lines with '[No Subject]'
> in search and show mode.  Apparently this was needed to circumvent
> some bug in the printing code, but there was no need for it search or
> show, and it is definitely not desirable, so we undo it here (a revert
> is no longer feasible).  We should not be modifying strings in the
> original message without good reason, or without a clear indication
> that we are doing so, neither of which apply in this case.  For
> further discussion see [0].
>
> [0] id:"1327918561-16245-3-git-send-email-dme@dme.org"
> ---

I agree. LGTM.

Tomi

> Sorry, there was a small bug in the previous version (notmuch-print.el
> was mistakenly modified).
>
>  emacs/notmuch-show.el |    5 +----
>  emacs/notmuch.el      |    5 ++---
>  2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 30b26d1..1e55099 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1075,7 +1075,7 @@ function is used."
>        (run-hooks 'notmuch-show-hook))
>  
>      ;; Set the header line to the subject of the first message.
> -    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-pretty-subject)))))
> +    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-subject)))))
>  
>  (defun notmuch-show-capture-state ()
>    "Capture the state of the current buffer.
> @@ -1375,9 +1375,6 @@ current thread."
>  (defun notmuch-show-get-depth ()
>    (notmuch-show-get-prop :depth))
>  
> -(defun notmuch-show-get-pretty-subject ()
> -  (notmuch-prettify-subject (notmuch-show-get-subject)))
> -
>  (defun notmuch-show-set-tags (tags)
>    "Set the tags of the current message."
>    (notmuch-show-set-prop :tags tags)
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index ba833e6..326645d 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -507,7 +507,7 @@ Complete list of currently available key bindings:
>    "Display the currently selected thread."
>    (interactive)
>    (let ((thread-id (notmuch-search-find-thread-id))
> -	(subject (notmuch-prettify-subject (notmuch-search-find-subject))))
> +	(subject (notmuch-search-find-subject)))
>      (if (> (length thread-id) 0)
>  	(notmuch-show thread-id
>  		      (current-buffer)
> @@ -877,8 +877,7 @@ non-authors is found, assume that all of the authors match."
>  		      ;; We currently just throw away excluded matches.
>  		      (unless (eq (aref count 1) ?0)
>  			(let ((beg (point)))
> -			  (notmuch-search-show-result date count authors
> -						      (notmuch-prettify-subject subject) tags)
> +			  (notmuch-search-show-result date count authors subject tags)
>  			  (notmuch-search-color-line beg (point) tag-list)
>  			  (put-text-property beg (point) 'notmuch-search-thread-id thread-id)
>  			  (put-text-property beg (point) 'notmuch-search-authors authors)
> -- 
> 1.7.9.5
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: do not modify subject in search or show

[David Bremner]

Jameson Graef Rollins <jrollins@finestructure.net> writes:
> A previous patch [0] replaced blank subject lines with '[No Subject]'
> in search and show mode.  

pushed.

d