Re: [PATCH] Add a configure flag to disable rpaths

[Tomi Ollila <tomi.ollila@iki.fi>]

On Tue, Feb 26 2019, Luis Ressel wrote:

although the commit message is a bit terse, this change looks simple and
reasonable enough to be pushed (i.e. if i think hard I can see reason
for this change even it is not described in commit message ;D)

Tomi

> ---
>  configure | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index a6f5dfa2..5e7e5aa9 100755
> --- a/configure
> +++ b/configure
> @@ -82,6 +82,7 @@ WITH_API_DOCS=1
>  WITH_EMACS=1
>  WITH_DESKTOP=1
>  WITH_BASH=1
> +WITH_RPATH=1
>  WITH_RUBY=1
>  WITH_ZSH=1
>  WITH_RETRY_LOCK=1
> @@ -241,6 +242,14 @@ for option; do
>  	fi
>      elif [ "${option}" = '--without-bash-completion' ] ; then
>  	WITH_BASH=0
> +    elif [ "${option%%=*}" = '--with-rpath' ]; then
> +	if [ "${option#*=}" = 'no' ]; then
> +	    WITH_RPATH=0
> +	else
> +	    WITH_RPATH=1
> +	fi
> +    elif [ "${option}" = '--without-rpath' ] ; then
> +	WITH_RPATH=0
>      elif [ "${option%%=*}" = '--with-ruby' ]; then
>  	if [ "${option#*=}" = 'no' ]; then
>  	    WITH_RUBY=0
> @@ -928,7 +937,7 @@ fi
>  rm -f compat/check_asctime
>  
>  printf "Checking for rpath support... "
> -if ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1
> +if [ $WITH_RPATH = "1" ] && ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1
>  then
>      printf "Yes.\n"
>      rpath_ldflags="-Wl,--enable-new-dtags -Wl,-rpath,\$(libdir)"
> -- 
> 2.19.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch