From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 334CE6DE0E7F
 for <notmuch@notmuchmail.org>; Thu, 28 Feb 2019 11:41:13 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.459
X-Spam-Level: 
X-Spam-Status: No, score=0.459 tagged_above=-999 required=5 tests=[AWL=-0.193, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 7TfMI5Ae2nUr for <notmuch@notmuchmail.org>;
 Thu, 28 Feb 2019 11:41:11 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 9F5FA6DE023A
 for <notmuch@notmuchmail.org>; Thu, 28 Feb 2019 11:41:10 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 84820100084;
 Thu, 28 Feb 2019 21:41:04 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Luis Ressel <aranea@aixah.de>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Add a configure flag to disable rpaths
In-Reply-To: <20190226020649.5407-1-aranea@aixah.de>
References: <20190226020649.5407-1-aranea@aixah.de>
User-Agent: Notmuch/0.28+29~ga10f231 (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 28 Feb 2019 21:41:04 +0200
Message-ID: <m2lg1z1z1r.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Feb 2019 19:41:13 -0000

On Tue, Feb 26 2019, Luis Ressel wrote:

although the commit message is a bit terse, this change looks simple and
reasonable enough to be pushed (i.e. if i think hard I can see reason
for this change even it is not described in commit message ;D)

Tomi

> ---
>  configure | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index a6f5dfa2..5e7e5aa9 100755
> --- a/configure
> +++ b/configure
> @@ -82,6 +82,7 @@ WITH_API_DOCS=1
>  WITH_EMACS=1
>  WITH_DESKTOP=1
>  WITH_BASH=1
> +WITH_RPATH=1
>  WITH_RUBY=1
>  WITH_ZSH=1
>  WITH_RETRY_LOCK=1
> @@ -241,6 +242,14 @@ for option; do
>  	fi
>      elif [ "${option}" = '--without-bash-completion' ] ; then
>  	WITH_BASH=0
> +    elif [ "${option%%=*}" = '--with-rpath' ]; then
> +	if [ "${option#*=}" = 'no' ]; then
> +	    WITH_RPATH=0
> +	else
> +	    WITH_RPATH=1
> +	fi
> +    elif [ "${option}" = '--without-rpath' ] ; then
> +	WITH_RPATH=0
>      elif [ "${option%%=*}" = '--with-ruby' ]; then
>  	if [ "${option#*=}" = 'no' ]; then
>  	    WITH_RUBY=0
> @@ -928,7 +937,7 @@ fi
>  rm -f compat/check_asctime
>  
>  printf "Checking for rpath support... "
> -if ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1
> +if [ $WITH_RPATH = "1" ] && ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1
>  then
>      printf "Yes.\n"
>      rpath_ldflags="-Wl,--enable-new-dtags -Wl,-rpath,\$(libdir)"
> -- 
> 2.19.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch