unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: call notmuch-show instead notmuch-search in buttonised id: links
@ 2011-12-23  4:55 Jameson Graef Rollins
  2011-12-23 10:07 ` Xavier Maillard
  0 siblings, 1 reply; 2+ messages in thread
From: Jameson Graef Rollins @ 2011-12-23  4:55 UTC (permalink / raw)
  To: Notmuch Mail

Since message-ids necessarily match just a single message, there's no
reason to do a search for the id before viewing the actual message;
the search just becomes an extra screen to click through.  Clicking on
an id: links now just jumps straight to the message itself.
---
 emacs/notmuch-show.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 98db8f2..623d521 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -803,7 +803,7 @@ a corresponding notmuch search."
       (remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)
       (make-text-button (match-beginning 0) (match-end 0)
 			'action `(lambda (arg)
-				   (notmuch-search ,(match-string-no-properties 0)))
+				   (notmuch-show ,(match-string-no-properties 0)))
 			'follow-link t
 			'help-echo "Mouse-1, RET: search for this message"
 			'face goto-address-mail-face))))
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] emacs: call notmuch-show instead notmuch-search in buttonised id: links
  2011-12-23  4:55 [PATCH] emacs: call notmuch-show instead notmuch-search in buttonised id: links Jameson Graef Rollins
@ 2011-12-23 10:07 ` Xavier Maillard
  0 siblings, 0 replies; 2+ messages in thread
From: Xavier Maillard @ 2011-12-23 10:07 UTC (permalink / raw)
  To: Jameson Graef Rollins, Notmuch Mail

Hi Jameson,

On Thu, 22 Dec 2011 20:55:48 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through.  Clicking on
> an id: links now just jumps straight to the message itself.

Definetely +1 for this patch !

/Xavier

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-12-23  9:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-23  4:55 [PATCH] emacs: call notmuch-show instead notmuch-search in buttonised id: links Jameson Graef Rollins
2011-12-23 10:07 ` Xavier Maillard

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).