From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: fix whitespace/indentation in symbol-test
Date: Sun, 06 Sep 2015 12:23:57 +0300 [thread overview]
Message-ID: <m2k2s3295e.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1441392555-20056-1-git-send-email-jani@nikula.org>
On Fri, Sep 04 2015, Jani Nikula <jani@nikula.org> wrote:
> Not of much consequence, but makes it nicer to do further edits.
> ---
These 2 patches LGTM ! +1! :D
> test/symbol-test.cc | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/test/symbol-test.cc b/test/symbol-test.cc
> index fb77b418a1a8..77dbc1af44b2 100644
> --- a/test/symbol-test.cc
> +++ b/test/symbol-test.cc
> @@ -3,23 +3,25 @@
> #include <xapian.h>
> #include <notmuch.h>
>
> +int main (int argc, char** argv)
> +{
> + notmuch_database_t *notmuch;
> + char *message = NULL;
>
> -int main(int argc, char** argv) {
> - notmuch_database_t *notmuch;
> - char *message = NULL;
> + if (notmuch_database_open_verbose (argv[1], NOTMUCH_DATABASE_MODE_READ_ONLY,
> + ¬much, &message)) {
> + if (message) {
> + fputs (message, stderr);
> + free (message);
> + }
> + }
>
> - if (notmuch_database_open_verbose (argv[1], NOTMUCH_DATABASE_MODE_READ_ONLY, ¬much, &message))
> - if (message) {
> - fputs (message, stderr);
> - free (message);
> - }
> + try {
> + (void) new Xapian::WritableDatabase (argv[2], Xapian::DB_OPEN);
> + } catch (const Xapian::Error &error) {
> + printf("caught %s\n", error.get_msg().c_str());
> + return 0;
> + }
>
> - try {
> - (void) new Xapian::WritableDatabase(argv[2], Xapian::DB_OPEN);
> - } catch (const Xapian::Error &error) {
> - printf("caught %s\n", error.get_msg().c_str());
> - return 0;
> - }
> -
> - return 1;
> + return 1;
> }
> --
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2015-09-06 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 18:49 [PATCH 1/2] test: fix whitespace/indentation in symbol-test Jani Nikula
2015-09-04 18:49 ` [PATCH 2/2] test: check argc " Jani Nikula
2015-09-07 12:45 ` David Bremner
2015-09-23 18:48 ` [PATCH v2] " Jani Nikula
2015-09-24 10:38 ` David Bremner
2015-09-06 9:23 ` Tomi Ollila [this message]
2015-09-07 12:51 ` [PATCH 1/2] test: fix whitespace/indentation " David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k2s3295e.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).