unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH 2/2] test: check argc in symbol-test
Date: Fri,  4 Sep 2015 21:49:15 +0300	[thread overview]
Message-ID: <1441392555-20056-2-git-send-email-jani@nikula.org> (raw)
In-Reply-To: <1441392555-20056-1-git-send-email-jani@nikula.org>

Check argc mainly to fix unused parameter warning:

test/symbol-test.cc:7:14: warning: unused parameter ‘argc’ [-Wunused-parameter]
  int main(int argc, char** argv) {
               ^

This makes more sense than telling the compiler it's unused on
purpose.
---
 test/symbol-test.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/symbol-test.cc b/test/symbol-test.cc
index 77dbc1af44b2..23583bfc11b5 100644
--- a/test/symbol-test.cc
+++ b/test/symbol-test.cc
@@ -8,6 +8,9 @@ int main (int argc, char** argv)
     notmuch_database_t *notmuch;
     char *message = NULL;
 
+    if (argc != 2)
+	return 1;
+
     if (notmuch_database_open_verbose (argv[1], NOTMUCH_DATABASE_MODE_READ_ONLY,
 				       &notmuch, &message)) {
 	if (message) {
-- 
2.1.4

  reply	other threads:[~2015-09-04 18:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 18:49 [PATCH 1/2] test: fix whitespace/indentation in symbol-test Jani Nikula
2015-09-04 18:49 ` Jani Nikula [this message]
2015-09-07 12:45   ` [PATCH 2/2] test: check argc " David Bremner
2015-09-23 18:48     ` [PATCH v2] " Jani Nikula
2015-09-24 10:38       ` David Bremner
2015-09-06  9:23 ` [PATCH 1/2] test: fix whitespace/indentation " Tomi Ollila
2015-09-07 12:51 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441392555-20056-2-git-send-email-jani@nikula.org \
    --to=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).