From: Tomi Ollila <tomi.ollila@iki.fi>
To: Floris Bruynooghe <flub@devork.be>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] test: pytest runner for the test suite
Date: Tue, 10 Apr 2018 22:28:08 +0300 [thread overview]
Message-ID: <m2h8oic14n.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87o9it260g.fsf@powell.devork.be>
On Sun, Apr 08 2018, Floris Bruynooghe wrote:
> This series looks good to me, would be great to have! Do you want to
> commit them this or should I just incorporate it and submit together
> with tests once actual tests exist. You could always commit with a ``def
> test_dummy(): assert True`` or something if you like.
I'd say incorporate and submit, have some real tests, remove that
*known_broken* line and so on...
Tomi
>
> Thanks!
> Floris
>
>
> On Sat 07 Apr 2018 at 18:39 -0300, David Bremner wrote:
>
>> The 'test_subtest_known_broken' should be removed when there are
>> actual tests to run.
>>
>> Based on a function from Tomi [1]
>>
>> [1]: id:m2r2nq23r9.fsf@guru.guru-group.fi
>> ---
>> test/T391-pytest.sh | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>> create mode 100755 test/T391-pytest.sh
>>
>> diff --git a/test/T391-pytest.sh b/test/T391-pytest.sh
>> new file mode 100755
>> index 00000000..9ac7aabe
>> --- /dev/null
>> +++ b/test/T391-pytest.sh
>> @@ -0,0 +1,14 @@
>> +#!/usr/bin/env bash
>> +test_description="python bindings (pytest)"
>> +. $(dirname "$0")/test-lib.sh || exit 1
>> +
>> +test_require_external_prereq ${NOTMUCH_PYTHON}
>> +
>> +for bin in ${NOTMUCH_PYTEST_PYTHONS}; do
>> + test_begin_subtest "pytest ($bin)"
>> + test_subtest_known_broken
>> + PYTHONPATH="$NOTMUCH_SRCDIR/bindings/python${PYTHONPATH:+:$PYTHONPATH}" \
>> + test_expect_success "$bin -m pytest $NOTMUCH_SRCDIR/bindings/python"
>> +done
>> +
>> +test_done
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2018-04-10 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 11:08 experimenting with pytest tests Floris Bruynooghe
2018-04-07 19:52 ` Tomi Ollila
2018-04-07 21:39 ` remix of pytest runner David Bremner
2018-04-07 21:39 ` [PATCH 1/2] configure: detect which versions of python can run pytest David Bremner
2018-04-07 21:55 ` Tomi Ollila
2018-04-07 22:04 ` Tomi Ollila
2018-04-07 21:39 ` [PATCH 2/2] test: pytest runner for the test suite David Bremner
2018-04-08 13:15 ` Floris Bruynooghe
2018-04-10 19:28 ` Tomi Ollila [this message]
[not found] ` <87po39uz0z.fsf@tethera.net>
2018-04-13 19:29 ` Floris Bruynooghe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2h8oic14n.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=flub@devork.be \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).