From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id D108E6DE021A
 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2018 12:28:16 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.477
X-Spam-Level: 
X-Spam-Status: No, score=0.477 tagged_above=-999 required=5 tests=[AWL=-0.175, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 6NsTMXRUvX5x for <notmuch@notmuchmail.org>;
 Tue, 10 Apr 2018 12:28:16 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id E59676DE0204
 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2018 12:28:15 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 46C451000AF;
 Tue, 10 Apr 2018 22:28:08 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Floris Bruynooghe <flub@devork.be>, David Bremner <david@tethera.net>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] test: pytest runner for the test suite
In-Reply-To: <87o9it260g.fsf@powell.devork.be>
References: <m2r2nq23r9.fsf@guru.guru-group.fi>
 <20180407213934.11550-1-david@tethera.net>
 <20180407213934.11550-3-david@tethera.net> <87o9it260g.fsf@powell.devork.be>
User-Agent: Notmuch/0.26~rc0+5~gaec2eb0 (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Tue, 10 Apr 2018 22:28:08 +0300
Message-ID: <m2h8oic14n.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2018 19:28:16 -0000

On Sun, Apr 08 2018, Floris Bruynooghe wrote:

> This series looks good to me, would be great to have!  Do you want to
> commit them this or should I just incorporate it and submit together
> with tests once actual tests exist.  You could always commit with a ``def
> test_dummy(): assert True`` or something if you like.

I'd say incorporate and submit, have some real tests, remove that
*known_broken* line and so on...

Tomi


>
> Thanks!
> Floris
>
>
> On Sat 07 Apr 2018 at 18:39 -0300, David Bremner wrote:
>
>> The 'test_subtest_known_broken' should be removed when there are
>> actual tests to run.
>>
>> Based on a function from Tomi [1]
>>
>> [1]: id:m2r2nq23r9.fsf@guru.guru-group.fi
>> ---
>>  test/T391-pytest.sh | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>  create mode 100755 test/T391-pytest.sh
>>
>> diff --git a/test/T391-pytest.sh b/test/T391-pytest.sh
>> new file mode 100755
>> index 00000000..9ac7aabe
>> --- /dev/null
>> +++ b/test/T391-pytest.sh
>> @@ -0,0 +1,14 @@
>> +#!/usr/bin/env bash
>> +test_description="python bindings (pytest)"
>> +. $(dirname "$0")/test-lib.sh || exit 1
>> +
>> +test_require_external_prereq ${NOTMUCH_PYTHON}
>> +
>> +for bin in ${NOTMUCH_PYTEST_PYTHONS}; do
>> +    test_begin_subtest "pytest ($bin)"
>> +      test_subtest_known_broken
>> +       PYTHONPATH="$NOTMUCH_SRCDIR/bindings/python${PYTHONPATH:+:$PYTHONPATH}" \
>> +                 test_expect_success "$bin -m pytest $NOTMUCH_SRCDIR/bindings/python"
>> +done
>> +
>> +test_done
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch