[PATCH] python: support relative path in default database

[PATCH] python: support relative path in default database

[Doan Tran Cong Danh]

From notmuch 0.28, notmuch support relative database path in
notmuch-config(1), but python binding haven't taught this yet.

afew denied to work with a perfectly fine notmuch-config due to this.
---
 bindings/python/notmuch/database.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py
index 342d665a..88ca836e 100644
--- a/bindings/python/notmuch/database.py
+++ b/bindings/python/notmuch/database.py
@@ -675,7 +675,10 @@ class Database(object):
         if not config.has_option('database', 'path'):
             raise NotmuchError(message="No DB path specified"
                                        " and no user default found")
-        return config.get('database', 'path')
+        db_path = config.get('database', 'path')
+        if not os.path.isabs(db_path):
+            db_path = os.path.expanduser(os.path.join("~", db_path))
+        return db_path
 
     """notmuch_database_get_config"""
     _get_config = nmlib.notmuch_database_get_config
-- 
2.21.0

Re: [PATCH] python: support relative path in default database

[David Edmondson]

Looks good. Sorry for missing this.

On Friday, 2019-04-19 at 10:56:59 +07, Doan Tran Cong Danh wrote:

> From notmuch 0.28, notmuch support relative database path in
> notmuch-config(1), but python binding haven't taught this yet.
>
> afew denied to work with a perfectly fine notmuch-config due to this.
> ---
>  bindings/python/notmuch/database.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py
> index 342d665a..88ca836e 100644
> --- a/bindings/python/notmuch/database.py
> +++ b/bindings/python/notmuch/database.py
> @@ -675,7 +675,10 @@ class Database(object):
>          if not config.has_option('database', 'path'):
>              raise NotmuchError(message="No DB path specified"
>                                         " and no user default found")
> -        return config.get('database', 'path')
> +        db_path = config.get('database', 'path')
> +        if not os.path.isabs(db_path):
> +            db_path = os.path.expanduser(os.path.join("~", db_path))
> +        return db_path
>  
>      """notmuch_database_get_config"""
>      _get_config = nmlib.notmuch_database_get_config
> -- 
> 2.21.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

dme.
-- 
But are you safe Miss Gradenko?

Re: [PATCH] python: support relative path in default database

[David Bremner]

Doan Tran Cong Danh <congdanhqx@gmail.com> writes:

> From notmuch 0.28, notmuch support relative database path in
> notmuch-config(1), but python binding haven't taught this yet.
>
> afew denied to work with a perfectly fine notmuch-config due to this.

pushed to  master

d