unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* Fix for notmuch-search autoload cookie
@ 2016-12-08  0:45 David Bremner
  2016-12-08  0:45 ` [PATCH 1/2] emacs: restore autoload cookie for notmuch-search David Bremner
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: David Bremner @ 2016-12-08  0:45 UTC (permalink / raw)
  To: notmuch

If your using the elpa packages (e.g. in recent debian packages), you might have
noticed that the autoloading of notmuch-search was not working.

This is a fix for that. You can test it by running:

emacs -q
M-x package-initialize
M-x notmuch-search

Before this patch, it won't work; after, it will (assuming you install
the elpa package).

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] emacs: restore autoload cookie for notmuch-search
  2016-12-08  0:45 Fix for notmuch-search autoload cookie David Bremner
@ 2016-12-08  0:45 ` David Bremner
  2016-12-15 13:01   ` David Bremner
  2016-12-08  0:45 ` [PATCH 2/2] NEWS: announce autoload fix David Bremner
  2016-12-10 19:43 ` Fix for notmuch-search autoload cookie Tomi Ollila
  2 siblings, 1 reply; 5+ messages in thread
From: David Bremner @ 2016-12-08  0:45 UTC (permalink / raw)
  To: notmuch

The cookie only applies to next form, so in the previous location it
applied to the put, rather than the function.
---
 emacs/notmuch.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 68a4c0b..46f14fe 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -931,8 +931,8 @@ PROMPT is the string to prompt with."
   "Return the current query in this search buffer"
   notmuch-search-query-string)
 
-;;;###autoload
 (put 'notmuch-search 'notmuch-doc "Search for messages.")
+;;;###autoload
 (defun notmuch-search (&optional query oldest-first target-thread target-line)
   "Display threads matching QUERY in a notmuch-search buffer.
 
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] NEWS: announce autoload fix
  2016-12-08  0:45 Fix for notmuch-search autoload cookie David Bremner
  2016-12-08  0:45 ` [PATCH 1/2] emacs: restore autoload cookie for notmuch-search David Bremner
@ 2016-12-08  0:45 ` David Bremner
  2016-12-10 19:43 ` Fix for notmuch-search autoload cookie Tomi Ollila
  2 siblings, 0 replies; 5+ messages in thread
From: David Bremner @ 2016-12-08  0:45 UTC (permalink / raw)
  To: notmuch

---
 NEWS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/NEWS b/NEWS
index c0aa479..a7d4c20 100644
--- a/NEWS
+++ b/NEWS
@@ -10,6 +10,11 @@ Improve error handling in notmuch insert
   filesystem.  Certain errors during `notmuch insert` most likely to
   be temporary return EX_TEMPFAIL.
 
+Emacs
+-----
+
+Restore autoload cookie for notmuch-search.
+
 Notmuch 0.23.3 (2016-11-27)
 ===========================
 
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Fix for notmuch-search autoload cookie
  2016-12-08  0:45 Fix for notmuch-search autoload cookie David Bremner
  2016-12-08  0:45 ` [PATCH 1/2] emacs: restore autoload cookie for notmuch-search David Bremner
  2016-12-08  0:45 ` [PATCH 2/2] NEWS: announce autoload fix David Bremner
@ 2016-12-10 19:43 ` Tomi Ollila
  2 siblings, 0 replies; 5+ messages in thread
From: Tomi Ollila @ 2016-12-10 19:43 UTC (permalink / raw)
  To: David Bremner, notmuch

On Thu, Dec 08 2016, David Bremner <david@tethera.net> wrote:

> If your using the elpa packages (e.g. in recent debian packages), you might have
> noticed that the autoloading of notmuch-search was not working.
>
> This is a fix for that. You can test it by running:
>
> emacs -q
> M-x package-initialize
> M-x notmuch-search
>
> Before this patch, it won't work; after, it will (assuming you install
> the elpa package).

Looks trivial enough to me :D

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] emacs: restore autoload cookie for notmuch-search
  2016-12-08  0:45 ` [PATCH 1/2] emacs: restore autoload cookie for notmuch-search David Bremner
@ 2016-12-15 13:01   ` David Bremner
  0 siblings, 0 replies; 5+ messages in thread
From: David Bremner @ 2016-12-15 13:01 UTC (permalink / raw)
  To: notmuch

David Bremner <david@tethera.net> writes:

> The cookie only applies to next form, so in the previous location it
> applied to the put, rather than the function.

series pushed to origin and release

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-12-15 13:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-08  0:45 Fix for notmuch-search autoload cookie David Bremner
2016-12-08  0:45 ` [PATCH 1/2] emacs: restore autoload cookie for notmuch-search David Bremner
2016-12-15 13:01   ` David Bremner
2016-12-08  0:45 ` [PATCH 2/2] NEWS: announce autoload fix David Bremner
2016-12-10 19:43 ` Fix for notmuch-search autoload cookie Tomi Ollila

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).