* [PATCH] vim: Use non-deprecated method parse instead of new.
@ 2019-03-21 15:39 Nicolas Lesser
2019-03-30 20:34 ` Tomi Ollila
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Lesser @ 2019-03-21 15:39 UTC (permalink / raw)
To: notmuch
---
vim/notmuch.vim | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vim/notmuch.vim b/vim/notmuch.vim
index ad8b7c80..541698cd 100644
--- a/vim/notmuch.vim
+++ b/vim/notmuch.vim
@@ -666,7 +666,7 @@ ruby << EOF
date = Time.at(e.newest_date).strftime(date_fmt)
subject = e.messages.first['subject']
if $mail_installed
- subject = Mail::Field.new("Subject: " + subject).to_s
+ subject = Mail::Field.parse("Subject: " + subject).to_s
else
subject = subject.force_encoding('utf-8')
end
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vim: Use non-deprecated method parse instead of new.
2019-03-21 15:39 [PATCH] vim: Use non-deprecated method parse instead of new Nicolas Lesser
@ 2019-03-30 20:34 ` Tomi Ollila
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Ollila @ 2019-03-30 20:34 UTC (permalink / raw)
To: Nicolas Lesser, notmuch
On Thu, Mar 21 2019, Nicolas Lesser wrote:
2 emails about this same change, this without typo :D
But, in order to someone(tm) to review these changes (especially, since not
everybody can test these changes), we'd need more content in commit
message.
https://notmuchmail.org/contributing/ is good place to look what helps
Tomi
> ---
> vim/notmuch.vim | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vim/notmuch.vim b/vim/notmuch.vim
> index ad8b7c80..541698cd 100644
> --- a/vim/notmuch.vim
> +++ b/vim/notmuch.vim
> @@ -666,7 +666,7 @@ ruby << EOF
> date = Time.at(e.newest_date).strftime(date_fmt)
> subject = e.messages.first['subject']
> if $mail_installed
> - subject = Mail::Field.new("Subject: " + subject).to_s
> + subject = Mail::Field.parse("Subject: " + subject).to_s
> else
> subject = subject.force_encoding('utf-8')
> end
> --
> 2.21.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-30 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 15:39 [PATCH] vim: Use non-deprecated method parse instead of new Nicolas Lesser
2019-03-30 20:34 ` Tomi Ollila
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).