From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/3] Rewrite default reply format
Date: Sat, 24 Mar 2012 12:06:06 +0200 [thread overview]
Message-ID: <m2d382ia9d.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1332473647-9133-1-git-send-email-amdragon@mit.edu>
Austin Clements <amdragon@MIT.EDU> writes:
> The default reply format is the last bastion of the old message
> formatter style. This series converts it to the new self-recursive
> style. After this, there will be one last series to rip out the
> compatibility code and do final cleanup.
Works fine, patches look good... just 2 "spacing" questions:
in id:"1332473647-9133-2-git-send-email-amdragon@mit.edu"
+ typedef enum {
+ NOTMUCH_SHOW_TEXT_PART_REPLY = 1<<0,
+ } notmuch_show_text_part_flags;
Should this be like: NOTMUCH_SHOW_TEXT_PART_REPLY = (1 << 0),
and this
+ * If flags&NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each
+ * output line.
+ *
like:
+ * If flags & NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each
Tomi
next prev parent reply other threads:[~2012-03-24 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 3:34 [PATCH 0/3] Rewrite default reply format Austin Clements
2012-03-23 3:34 ` [PATCH 1/3] show/reply: Unify the code that extracts text parts Austin Clements
2012-03-23 3:34 ` [PATCH 2/3] reply: Convert default reply format to self-recursive style Austin Clements
2012-03-23 3:34 ` [PATCH 3/3] reply: Move reply citation printing to the recursive MIME walk Austin Clements
2012-03-24 10:06 ` Tomi Ollila [this message]
2012-03-27 21:57 ` [PATCH 0/3] Rewrite default reply format Austin Clements
2012-03-27 21:59 ` [PATCH v2 " Austin Clements
2012-03-27 21:59 ` [PATCH v2 1/3] show/reply: Unify the code that extracts text parts Austin Clements
2012-03-27 21:59 ` [PATCH v2 2/3] reply: Convert default reply format to self-recursive style Austin Clements
2012-03-27 21:59 ` [PATCH v2 3/3] reply: Move reply citation printing to the recursive MIME walk Austin Clements
2012-03-31 11:31 ` [PATCH v2 0/3] Rewrite default reply format David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d382ia9d.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).