From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 0AFC2431FAF
	for <notmuch@notmuchmail.org>; Sat, 24 Mar 2012 03:06:16 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id cV86dYXVGGYg for <notmuch@notmuchmail.org>;
	Sat, 24 Mar 2012 03:06:15 -0700 (PDT)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id 1A786431FAE
	for <notmuch@notmuchmail.org>; Sat, 24 Mar 2012 03:06:15 -0700 (PDT)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id 55EB668055; Sat, 24 Mar 2012 12:06:06 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/3] Rewrite default reply format
In-Reply-To: <1332473647-9133-1-git-send-email-amdragon@mit.edu>
References: <1332473647-9133-1-git-send-email-amdragon@mit.edu>User-Agent: Notmuch/0.12+71~gdacf76b
	(http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sat, 24 Mar 2012 12:06:06 +0200
Message-ID: <m2d382ia9d.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Mar 2012 10:06:16 -0000

Austin Clements <amdragon@MIT.EDU> writes:

> The default reply format is the last bastion of the old message
> formatter style.  This series converts it to the new self-recursive
> style.  After this, there will be one last series to rip out the
> compatibility code and do final cleanup.

Works fine, patches look good... just 2 "spacing" questions:

in id:"1332473647-9133-2-git-send-email-amdragon@mit.edu"

+ typedef enum {
+     NOTMUCH_SHOW_TEXT_PART_REPLY = 1<<0,
+ } notmuch_show_text_part_flags;

Should this be like: NOTMUCH_SHOW_TEXT_PART_REPLY = (1 << 0),

and this

+ * If flags&NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each
+ * output line.
+ *

like:

+ * If flags & NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each


Tomi