unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: "Örjan Ekeberg" <ekeberg@kth.se>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable
Date: Tue, 02 Apr 2019 00:24:16 +0300	[thread overview]
Message-ID: <m2d0m5l8qn.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20190330214821.4150-1-ekeberg@kth.se>

On Sat, Mar 30 2019, Örjan Ekeberg wrote:

> These patches implement a message-send-hook which uses a buffer-local variable
> to tag replied and forwarded messages.
>
> The first patch replaces the current heuristic hook for detecting reply
> messages with an explicit setting when the reply is composed.
>
> The second patch adds the corresponding mechanism for forwarded messages.
> This patch is on top of a previously submitted patch (for adding a References
> header), and will not apply cleanly without that.

I could comprehend most of the content -- cl loop is something that would
require more learning... but I believe it works...

two things

- I wonder whether we could drop (defun notmuch-message-mark-replied ()...)
  - why is it needed for backward compatibility ?
 
- A test of a few would be nice to see how this behaves -- and we can see
  that this still works e.g. on emacs 24...

Tomi


>
> Örjan Ekeberg (2):
>   emacs: Use a buffer-local variable to update tags when sending replies
>   emacs: Tag forwarded messages with +forwarded (customizable)
>
>  emacs/notmuch-message.el | 34 ++++++++++++++++++++++++++++++++--
>  emacs/notmuch-mua.el     | 26 +++++++++++++++++++-------
>  2 files changed, 51 insertions(+), 9 deletions(-)
>
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2019-04-01 21:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30 21:48 [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable Örjan Ekeberg
2019-03-30 21:48 ` [PATCH 1/2] emacs: Use a buffer-local variable to update tags when sending replies Örjan Ekeberg
2019-03-30 21:48 ` [PATCH 2/2] emacs: Tag forwarded messages with +forwarded (customizable) Örjan Ekeberg
2019-03-31 22:34 ` [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable Daniel Kahn Gillmor
2019-04-01 21:24 ` Tomi Ollila [this message]
2019-04-02  9:12   ` Örjan Ekeberg
2019-04-03 20:10     ` Tomi Ollila
2019-04-04 23:01       ` Örjan Ekeberg
2019-04-04 23:01         ` [PATCH v2 1/4] emacs: Add References header to forwarded messages Örjan Ekeberg
2019-04-04 23:01         ` [PATCH v2 2/4] emacs: Use a buffer-local variable to update tags when sending replies Örjan Ekeberg
2019-04-04 23:01         ` [PATCH v2 3/4] emacs: Tag forwarded messages with +forwarded (customizable) Örjan Ekeberg
2019-04-04 23:01         ` [PATCH v2 4/4] test: add test for checking forwarded messages Örjan Ekeberg
2019-04-07 19:39           ` Tomi Ollila
2019-04-07 20:24             ` Örjan Ekeberg
2019-04-08 14:21           ` David Edmondson
2019-04-10 12:19             ` Updated testing script Örjan Ekeberg
2019-04-10 12:19               ` [PATCH v3 4/4] test: add test for checking forwarded messages Örjan Ekeberg
2019-04-10 20:25                 ` Tomi Ollila
2019-04-11 11:26                   ` Örjan Ekeberg
2019-04-12 12:01         ` Updated version of the patch-set for tagging " Örjan Ekeberg
2019-04-12 12:01           ` [PATCH v4 1/4] emacs: Add References header to " Örjan Ekeberg
2019-04-12 12:01           ` [PATCH v4 2/4] emacs: Use a buffer-local variable to update tags when sending replies Örjan Ekeberg
2019-04-12 12:01           ` [PATCH v4 3/4] emacs: Tag forwarded messages with +forwarded (customizable) Örjan Ekeberg
2019-04-12 12:01           ` [PATCH v4 4/4] test: add test for checking forwarded messages Örjan Ekeberg
2019-04-13 10:19           ` Updated version of the patch-set for tagging " Tomi Ollila
2019-04-14 11:30           ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2d0m5l8qn.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=ekeberg@kth.se \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).