From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 1D2B36DE0F18 for ; Mon, 1 Apr 2019 14:24:26 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.452 X-Spam-Level: X-Spam-Status: No, score=0.452 tagged_above=-999 required=5 tests=[AWL=-0.200, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3iOHSv6JWq29 for ; Mon, 1 Apr 2019 14:24:24 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 825F56DE0EB7 for ; Mon, 1 Apr 2019 14:24:23 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 5735B10019F; Tue, 2 Apr 2019 00:24:17 +0300 (EEST) From: Tomi Ollila To: =?utf-8?Q?=C3=96rjan?= Ekeberg , notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable In-Reply-To: <20190330214821.4150-1-ekeberg@kth.se> References: <20190330214821.4150-1-ekeberg@kth.se> User-Agent: Notmuch/0.28.3+42~g7b16377 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 21:24:26 -0000 On Sat, Mar 30 2019, =C3=96rjan Ekeberg wrote: > These patches implement a message-send-hook which uses a buffer-local var= iable > to tag replied and forwarded messages. > > The first patch replaces the current heuristic hook for detecting reply > messages with an explicit setting when the reply is composed. > > The second patch adds the corresponding mechanism for forwarded messages. > This patch is on top of a previously submitted patch (for adding a Refere= nces > header), and will not apply cleanly without that. I could comprehend most of the content -- cl loop is something that would require more learning... but I believe it works... two things - I wonder whether we could drop (defun notmuch-message-mark-replied ()...) - why is it needed for backward compatibility ? =20 - A test of a few would be nice to see how this behaves -- and we can see that this still works e.g. on emacs 24... Tomi > > =C3=96rjan Ekeberg (2): > emacs: Use a buffer-local variable to update tags when sending replies > emacs: Tag forwarded messages with +forwarded (customizable) > > emacs/notmuch-message.el | 34 ++++++++++++++++++++++++++++++++-- > emacs/notmuch-mua.el | 26 +++++++++++++++++++------- > 2 files changed, 51 insertions(+), 9 deletions(-) > > --=20 > 2.20.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch