Re: [PATCH v3 0/8] nmbug-status: Python-3-compatibility and general refactoring

[Tomi Ollila <tomi.ollila@iki.fi>]

On Thu, Feb 13 2014, "W. Trevor King" <wking@tremily.us> wrote:

> The only changes since v2 [1] are related to our discussion of
> locale-based encodings vs. hardcoded UTF-8 [2,3,and descendants].
> This iteration addresses those concerns by rebasing the controversial
> commit (nmbug-status: Encode output using the user's locale) to the
> end of the series.  In order to address Tomi's hardcoded config
> encoding request [4,5] now that fd29d3f (nmbug-status: Decode Popen
> output using the user's locale, 2014-02-10) has landed in master, I
> think we should keep the output locale patch (7/8 in v3) and add an
> additional patch to hardcode _ENCODING (8/8 in v3).  The commit
> message for 8/8 was tricky, but I think the current wording expresses
> both the motivation for the hardcoded UTF-8, my acceptance of a
> hardcoded UTF-8, and my personal preference for respecting LANG ;).
> Suggestions for alternative wordings are welcome, especially since I
> try to explain both David and Tomi's perspectives :p.

Good stuff -- I did not have chance to test these yet...

> Cheers,
> Trevor

Tomi

>
> [1]: id:"cover.1392056624.git.wking@tremily.us"
>      http://thread.gmane.org/gmane.mail.notmuch.general/17167
> [2]: id:"87eh396e6e.fsf@zancas.localnet"
>      http://thread.gmane.org/gmane.mail.notmuch.general/17167/focus=17190
> [3]: id:"87a9dv52h4.fsf@zancas.localnet"
>      http://thread.gmane.org/gmane.mail.notmuch.general/17167/focus=17200
> [4]: id:"m2sirpu46i.fsf@guru.guru-group.fi"
>      http://article.gmane.org/gmane.mail.notmuch.general/17191
> [5]: id:"m2vbwj79lu.fsf@guru.guru-group.fi"
>      http://article.gmane.org/gmane.mail.notmuch.general/17209
>
> W. Trevor King (8):
>   nmbug-status: Anchor with h3 ids instead of a names
>   nmbug-status: Slug the title when using it as an id
>   nmbug-status: Use <code> and <p> markup where appropriate
>   nmbug-status: Color threads in HTML output
>   nmbug-status: Escape &, <, and > in HTML display data
>   nmbug-status: Add inter-message padding
>   nmbug-status: Encode output using the user's locale
>   nmbug-status: Hardcode UTF-8 instead of using the user's locale
>
>  devel/nmbug/nmbug-status | 96 ++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 76 insertions(+), 20 deletions(-)
>
> -- 
> 1.8.5.2.8.g0f6c0d1