unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "W. Trevor King" <wking@tremily.us>
To: notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: [PATCH v3 2/8] nmbug-status: Slug the title when using it as an id
Date: Thu, 13 Feb 2014 08:47:17 -0800	[thread overview]
Message-ID: <4755c683a14500c996683ef5cf271be3c7f4f9f3.1392309570.git.wking@tremily.us> (raw)
In-Reply-To: <cover.1392309570.git.wking@tremily.us>
In-Reply-To: <cover.1392309570.git.wking@tremily.us>

Also allow manual id overrides from the JSON config.  Sluggin avoids
errors like:

   Bad value '#Possible bugs' for attribute href on element a:
   Whitespace in fragment component. Use %20 in place of spaces.

from http://validator.w3.org.

I tried just quoting the titles (e.g. 'Possible%20bugs'), but that
didn't work (at least with Firefox 24.2.0).  Slugging avoids any
ambiguity over when the quotes are expanded in the client.  The specs
are unclear about quoting, saying only [1]:

  Value: Any string, with the following restrictions:

    must be at least one character long
    must not contain any space characters

[1]: http://dev.w3.org/html5/markup/global-attributes.html#common.attrs.id
---
 devel/nmbug/nmbug-status | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status
index 40e6896..9fde20e 100755
--- a/devel/nmbug/nmbug-status
+++ b/devel/nmbug/nmbug-status
@@ -21,6 +21,7 @@ except ImportError:  # Python 2
 import json
 import argparse
 import os
+import re
 import sys
 import subprocess
 
@@ -168,16 +169,20 @@ class Page (object):
 
 
 class HtmlPage (Page):
+    _slug_regexp = re.compile('\W+')
+
     def _write_header(self, views, stream):
         super(HtmlPage, self)._write_header(views=views, stream=stream)
         stream.write('<ul>\n')
         for view in views:
+            if 'id' not in view:
+                view['id'] = self._slug(view['title'])
             stream.write(
-                '<li><a href="#{title}">{title}</a></li>\n'.format(**view))
+                '<li><a href="#{id}">{title}</a></li>\n'.format(**view))
         stream.write('</ul>\n')
 
     def _write_view_header(self, view, stream):
-        stream.write('<h3 id="{title}">{title}</h3>\n'.format(**view))
+        stream.write('<h3 id="{id}">{title}</h3>\n'.format(**view))
         if 'comment' in view:
             stream.write(view['comment'])
             stream.write('\n')
@@ -224,6 +229,9 @@ class HtmlPage (Page):
                 ).format(**d)
         return (running_data, display_data)
 
+    def _slug(self, string):
+        return self._slug_regexp.sub('-', string)
+
 
 _PAGES['text'] = Page()
 _PAGES['html'] = HtmlPage(
-- 
1.8.5.2.8.g0f6c0d1

  parent reply	other threads:[~2014-02-13 16:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 16:47 [PATCH v3 0/8] nmbug-status: Python-3-compatibility and general refactoring W. Trevor King
2014-02-13 16:47 ` [PATCH v3 1/8] nmbug-status: Anchor with h3 ids instead of a names W. Trevor King
2014-02-13 16:47 ` W. Trevor King [this message]
2014-02-13 16:47 ` [PATCH v3 3/8] nmbug-status: Use <code> and <p> markup where appropriate W. Trevor King
2014-02-13 16:47 ` [PATCH v3 4/8] nmbug-status: Color threads in HTML output W. Trevor King
2014-02-14  1:58   ` David Bremner
2014-02-14  2:05     ` W. Trevor King
2014-02-13 16:47 ` [PATCH v3 5/8] nmbug-status: Escape &, <, and > in HTML display data W. Trevor King
2014-02-13 16:47 ` [PATCH v3 6/8] nmbug-status: Add inter-message padding W. Trevor King
2014-02-14  2:13   ` David Bremner
2014-02-14  4:07     ` W. Trevor King
2014-02-14 12:40       ` David Bremner
2014-02-13 16:47 ` [PATCH v3 7/8] nmbug-status: Encode output using the user's locale W. Trevor King
2014-02-13 17:42   ` W. Trevor King
2014-02-13 16:47 ` [PATCH v3 8/8] nmbug-status: Hardcode UTF-8 instead of " W. Trevor King
2014-02-13 17:14 ` [PATCH v3 0/8] nmbug-status: Python-3-compatibility and general refactoring Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4755c683a14500c996683ef5cf271be3c7f4f9f3.1392309570.git.wking@tremily.us \
    --to=wking@tremily.us \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).