[PATCH] emacs: hint that notmuch-mua-attachment-regexp is a regular expression

[PATCH] emacs: hint that notmuch-mua-attachment-regexp is a regular expression

[Daniel Kahn Gillmor]

Without this change, we see the following warnings during the build:

```
In toplevel form:
emacs/notmuch-mua.el:119:1:Warning: defcustom for
    ‘notmuch-mua-attachment-regexp’ fails to specify type
emacs/notmuch-mua.el:119:1:Warning: defcustom for
    ‘notmuch-mua-attachment-regexp’ fails to specify type
EMACS emacs/notmuch-show.elc
```
---
 emacs/notmuch-mua.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 94fa19d7..b1a31034 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -121,7 +121,8 @@ multiple parts get a header."
   "Message body text indicating that an attachment is expected.
 
 This is not used unless `notmuch-mua-attachment-check' is added
-to `notmuch-mua-send-hook'.")
+to `notmuch-mua-send-hook'."
+  :type '(regexp))
 
 ;;
 
-- 
2.20.1

Re: [PATCH] emacs: hint that notmuch-mua-attachment-regexp is a regular expression

[Örjan Ekeberg]

This addresses the same issue, and therefore overlaps with the patch
I submitted a week ago.
(id:20190415133519.4532-1-ekeberg@kth.se)

/Örjan


Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> Without this change, we see the following warnings during the build:
>
> ```
> In toplevel form:
> emacs/notmuch-mua.el:119:1:Warning: defcustom for
>     ‘notmuch-mua-attachment-regexp’ fails to specify type
> emacs/notmuch-mua.el:119:1:Warning: defcustom for
>     ‘notmuch-mua-attachment-regexp’ fails to specify type
> EMACS emacs/notmuch-show.elc
> ```
> ---
>  emacs/notmuch-mua.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 94fa19d7..b1a31034 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -121,7 +121,8 @@ multiple parts get a header."
>    "Message body text indicating that an attachment is expected.
>  
>  This is not used unless `notmuch-mua-attachment-check' is added
> -to `notmuch-mua-send-hook'.")
> +to `notmuch-mua-send-hook'."
> +  :type '(regexp))
>  
>  ;;
>  
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: hint that notmuch-mua-attachment-regexp is a regular expression

[Tomi Ollila]

On Sat, Apr 20 2019, Daniel Kahn Gillmor wrote:

> Without this change, we see the following warnings during the build:
>
> ```
> In toplevel form:
> emacs/notmuch-mua.el:119:1:Warning: defcustom for
>     ‘notmuch-mua-attachment-regexp’ fails to specify type
> emacs/notmuch-mua.el:119:1:Warning: defcustom for
>     ‘notmuch-mua-attachment-regexp’ fails to specify type
> EMACS emacs/notmuch-show.elc
> ```

LGTM. works as advertised.

Tomi

> ---
>  emacs/notmuch-mua.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 94fa19d7..b1a31034 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -121,7 +121,8 @@ multiple parts get a header."
>    "Message body text indicating that an attachment is expected.
>  
>  This is not used unless `notmuch-mua-attachment-check' is added
> -to `notmuch-mua-send-hook'.")
> +to `notmuch-mua-send-hook'."
> +  :type '(regexp))
>  
>  ;;
>  
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: hint that notmuch-mua-attachment-regexp is a regular expression

[Daniel Kahn Gillmor]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Mon 2019-04-22 11:33:34 +0200, Örjan Ekeberg wrote:
> This addresses the same issue, and therefore overlaps with the patch
> I submitted a week ago.
> (id:20190415133519.4532-1-ekeberg@kth.se)

sorry, i'd missed your earlier patch!  i agree that your patch is
obviously better than mine, thanks for pointing it out again.

I've marked my patch with notmuch::obsolete, and marked yours with
notmuch::trivial and notmuch::patch, as i don't think it needs any more
review, and should be merged.

        --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]