Re: [PATCH v4] test: emacs: new test "notmuch-search: change tags of all matching messages"

[Tomi Ollila <tomi.ollila@iki.fi>]

On Wed,  7 Mar 2012 20:49:52 +0100, Pieter Praet <pieter@praet.org> wrote:
> * test/emacs-search:
> 
>   - New subtest "notmuch-search: change tags of all matching messages":
>     `notmuch-search-tag-all' (bound to "*") adds and removes tags
>     to/from all messages which match the query used to populate the
>     current search buffer.
> ---
> 
> Moved to a separate file to prevent a merge conflict when applied in
> conjunction with the patches listed @ id:"877gz4dnl2.fsf@praet.org".

Hi Pieter!

I did the following script:

--8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--

#!/bin/sh

while read line
do
        case $line in id:*) notmuch show --format=mbox "$line"
        esac
done < "$0" | git am 
exit 0

id:"1329684990-12504-2-git-send-email-pieter@praet.org"
id:"1329684990-12504-3-git-send-email-pieter@praet.org"
id:"1329684990-12504-4-git-send-email-pieter@praet.org"

id:"1330122640-18895-2-git-send-email-pieter@praet.org"
id:"1330122640-18895-3-git-send-email-pieter@praet.org"

id:"1331149792-17192-1-git-send-email-pieter@praet.org"

--8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--

When executed on top of current master (c46764030d, 0.11.1-1-293-gc467640)
last patch (1331149792-17192-1..., this I'm replying to) fails as:

error: patch failed: test/notmuch-test:54
error: test/notmuch-test: patch does not apply


In order to get clear picture of the changes you wish to get
reviewed please provide cleanly applicable patchset.

The best possible way to inform what is to be reviewed
is

1) List of message id:s of the patches, in order those
   are to be applied.

2) Sha1 of the commit where this patchset applies cleanly
   (In this case I will do review even though it would not
    apply on top of current master (at that time) anymore --
    but *I* would not expect it to to be pushed until rebased
    patchset is sent again).

BR,

Tomi