From: Pieter Praet <pieter@praet.org>
To: Austin Clements <amdragon@MIT.EDU>, David Bremner <david@tethera.net>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on threads, not messages
Date: Wed, 16 Nov 2011 14:55:41 +0100 [thread overview]
Message-ID: <871ut8f9ya.fsf@praet.org> (raw)
In-Reply-To: <20111112163502.GE2658@mit.edu>
On Sat, 12 Nov 2011 11:35:02 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth David Bremner on Nov 12 at 11:13 am:
> > On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet <pieter@praet.org> wrote:
> > > In order to be consistent with `notmuch-search-{add,remove}-tag' ("+"/"-"),
> > > `notmuch-search-operate-all' ("*") should operate on matching threads
> > > instead of matching messages.
> > >
> >
> > As far as I can tell, the follow-up series for the race condition kindof
> > got stalled. Am I right in thinking this bug fix should still be
> > applied? I didn't see any review/feedback on the list.
>
> We concluded that fixing the tagging race correctly was actually a lot
> of work, which should be done but hasn't yet. We have to add message
> IDs or docids to the search results, which is difficult to do with the
> current text format, so rather than further entrenching ourselves, we
> should first we should migrate Emacs to using the JSON-based search
> output.
>
Yeah, sorry I haven't replied there yet. Still haven't found a
sufficiently uninterrupted stretch of time to give the *massive*
amount of work you did the attention it deserves.
> However, this series doesn't actually have much to do with the race.
Correct. Only patch #4 is more or less relevant to fixing the
`notmuch-search-operate-all' race condition (safety net for when
I make stupid mistakes).
Patches #1-3 should have been in a separate thread (or as updates in
their original thread [1]), but since #1 and #2 are mainly there to
support #3 and #3 is tagging-related, I though it wouldn't hurt to
include them.
Patches #5-6 are a matter of opinion:
> I think the question here is whether notmuch-search-operate-all should
> affect only matched messages or entire threads. It seems to me it
> should affect all threads, since that's what you're seeing visually,
> but other people may disagree.
>
Same here. I don't use it that often, but if its name includes
"operate-all", it should do just that, or the function should be
renamed.
> The test patches seem reasonable, though they could use a little
> review before being pushed.
I'd really appreciate it.
AFAIC, increasing test coverage should be a top priority.
Peace
--
Pieter
[1] id:"1305275652-22956-1-git-send-email-pieter@praet.org"
next prev parent reply other threads:[~2011-11-16 13:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 15:55 Extend test coverage wrt tagging Pieter Praet
2011-07-10 15:55 ` [PATCH 1/6] test: emacs: rename subtest "Reply within emacs" to "Compose reply in emacs" Pieter Praet
2011-07-10 15:55 ` [PATCH 2/6] test: emacs: add test for sending a reply from within Emacs Pieter Praet
2011-07-10 15:55 ` [PATCH 3/6] test: emacs: add test to verify that the message being replied to is tagged as such Pieter Praet
2011-07-10 15:55 ` [PATCH 4/6] test: emacs: add test for `notmuch-search-operate-all' Pieter Praet
2011-07-10 15:55 ` [PATCH 5/6] test: emacs: `notmuch-search-operate-all' should operate on threads, not messages Pieter Praet
2011-07-10 15:55 ` [PATCH 6/6] emacs: make `notmuch-search-operate-all' " Pieter Praet
2011-11-12 16:13 ` David Bremner
2011-11-12 16:35 ` Austin Clements
2011-11-16 13:55 ` Pieter Praet [this message]
2012-02-19 20:38 ` Pieter Praet
2012-02-19 20:38 ` [PATCH v2 1/4] test: emacs: rename subtest "Reply within emacs" Pieter Praet
2012-02-20 12:16 ` Dmitry Kurochkin
2012-02-19 20:38 ` [PATCH v2 2/4] test: emacs: new test "notmuch-search: replying to a thread (sending)" Pieter Praet
2012-02-19 21:04 ` Tomi Ollila
2012-02-22 18:49 ` Pieter Praet
2012-02-20 12:44 ` Dmitry Kurochkin
2012-02-22 18:51 ` Pieter Praet
2012-02-19 20:38 ` [PATCH v2 3/4] test: emacs: new test "notmuch-search: when reply is sent, parent message should be tagged 'replied'" Pieter Praet
2012-02-20 12:20 ` Dmitry Kurochkin
2012-02-22 18:52 ` Pieter Praet
2012-02-19 20:38 ` [PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags of all matching messages" Pieter Praet
2012-02-19 21:08 ` Tomi Ollila
2012-02-22 18:53 ` Pieter Praet
2012-02-20 12:25 ` Dmitry Kurochkin
2012-02-22 18:53 ` Pieter Praet
2012-02-22 18:54 ` [PATCH v3] " Pieter Praet
2012-03-07 19:49 ` [PATCH v4] " Pieter Praet
2012-03-11 18:42 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ut8f9ya.fsf@praet.org \
--to=pieter@praet.org \
--cc=amdragon@MIT.EDU \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).