From: David Edmondson <dme@dme.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.
Date: Mon, 06 Feb 2012 08:56:34 +0000 [thread overview]
Message-ID: <cunsjio49x9.fsf@hotblack-desiato.hh.sledj.net> (raw)
In-Reply-To: <87obtcbd29.fsf@servo.finestructure.net>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Mon, 06 Feb 2012 00:06:54 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Mon, 06 Feb 2012 07:47:38 +0000, David Edmondson <dme@dme.org> wrote:
> > On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > > Sorry to be so late on this, but I'm not a big fan of this new feature.
> > > I would prefer to always see the subject (or any other field for that
> > > matter) as is.
> >
> > The Emacs UI always replaced blank subjects with '[No Subject]' in
> > buffer names. The printing code also needed something other than a blank
> > subject for buffer renaming.
>
> I don't much care what the buffer name is. That seems to be a
> completely different issue to me.
I agree that they could be treated differently.
With blank subjects the printing code generated an error (because
`rename-buffer' doesn't like an empty string as the first argument), so
_some_ change is required.
> > Updating `notmuch-prettify-subject' to use a user configurable string
> > (that can be set to the empty string) sounds like a good idea. Please
> > ensure that the various other bits of code that require something other
> > than a blank subject still work properly.
>
> I am actually perfectly happy to see this patch reverted.
Whatever bremner decides.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2012-02-06 8:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 13:08 [PATCH 0/3] minor cleanup and improvements David Edmondson
2012-01-25 13:08 ` [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness David Edmondson
2012-01-25 13:08 ` [PATCH 2/3] emacs: Don't mark messages as "unsaved" when printing David Edmondson
2012-01-25 13:08 ` [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects David Edmondson
2012-01-25 13:13 ` David Edmondson
2012-01-25 13:48 ` [PATCH 0/3 v2] minor cleanup and improvements David Edmondson
2012-01-25 13:48 ` [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness David Edmondson
2012-01-28 5:09 ` Austin Clements
2012-01-30 9:16 ` David Edmondson
2012-01-25 13:48 ` [PATCH 2/3] emacs: Don't mark messages as "unsaved" when printing David Edmondson
2012-01-27 12:04 ` David Bremner
2012-01-27 12:05 ` David Bremner
2012-01-25 13:48 ` [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects David Edmondson
[not found] ` <874nvh5tro.fsf@qmul.ac.uk>
2012-01-27 10:28 ` David Edmondson
2012-01-27 13:31 ` Mark Walters
2012-01-27 13:39 ` David Edmondson
2012-01-27 10:32 ` Mark Walters
2012-01-28 5:22 ` Austin Clements
2012-01-27 9:26 ` [PATCH 0/3 v2] minor cleanup and improvements David Edmondson
2012-01-30 10:15 ` [PATCH 0/2 " David Edmondson
2012-01-30 10:16 ` [PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness David Edmondson
2012-01-30 23:46 ` Austin Clements
2012-01-31 6:15 ` David Edmondson
2012-01-30 10:16 ` [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects David Edmondson
2012-01-30 23:48 ` Austin Clements
2012-02-06 7:07 ` Jameson Graef Rollins
2012-02-06 7:47 ` David Edmondson
2012-02-06 8:06 ` Jameson Graef Rollins
2012-02-06 8:56 ` David Edmondson [this message]
2012-02-06 19:19 ` Jameson Graef Rollins
2012-02-06 19:34 ` David Edmondson
2012-02-06 19:50 ` Antoine Beaupré
2012-02-28 1:52 ` David Bremner
2012-01-30 10:18 ` [PATCH 0/2 v2] minor cleanup and improvements David Edmondson
2012-02-04 12:39 ` David Bremner
2012-02-06 21:30 ` [PATCH] emacs: Leave blank subjects alone by default David Edmondson
2012-02-12 20:51 ` Jameson Graef Rollins
2012-02-06 22:48 ` [PATCH v2] " David Edmondson
2012-02-12 8:52 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cunsjio49x9.fsf@hotblack-desiato.hh.sledj.net \
--to=dme@dme.org \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).