From: David Bremner <david@tethera.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Cc: "Antoine Beaupré" <anarcat@anarcat.ath.cx>
Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.
Date: Mon, 27 Feb 2012 21:52:38 -0400 [thread overview]
Message-ID: <8762eriv15.fsf@zancas.localnet> (raw)
In-Reply-To: <1327918561-16245-3-git-send-email-dme@dme.org>
On Mon, 30 Jan 2012 10:16:01 +0000, David Edmondson <dme@dme.org> wrote:
> ---
> emacs/notmuch-lib.el | 9 +++++++++
> emacs/notmuch-print.el | 8 ++++++--
> emacs/notmuch-show.el | 5 ++++-
> emacs/notmuch.el | 21 +++++++++------------
> 4 files changed, 28 insertions(+), 15 deletions(-)
Jameson and Antoine have asked for this patch to be reverted. As far as
I understand it the printing code actually crashes on blank subjects if
this patch is removed, so it seems to me that that (slightly) outweighs
the annoyance caused by printing [No Subject]. I don't find the
argument that different people are annoyed
I'd be willing to be convinced otherwise, but as it turns out the
question is somewhat academic; there have been enough changes that this
patch no longer reverts cleanly. So Someone (TM) will have to do some to
change the behaviour; it sounds like the sensible thing to do would be to move
notmuch-prettify-subject into notmuch-print.el and call it there.
d
next prev parent reply other threads:[~2012-02-28 1:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 13:08 [PATCH 0/3] minor cleanup and improvements David Edmondson
2012-01-25 13:08 ` [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness David Edmondson
2012-01-25 13:08 ` [PATCH 2/3] emacs: Don't mark messages as "unsaved" when printing David Edmondson
2012-01-25 13:08 ` [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects David Edmondson
2012-01-25 13:13 ` David Edmondson
2012-01-25 13:48 ` [PATCH 0/3 v2] minor cleanup and improvements David Edmondson
2012-01-25 13:48 ` [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness David Edmondson
2012-01-28 5:09 ` Austin Clements
2012-01-30 9:16 ` David Edmondson
2012-01-25 13:48 ` [PATCH 2/3] emacs: Don't mark messages as "unsaved" when printing David Edmondson
2012-01-27 12:04 ` David Bremner
2012-01-27 12:05 ` David Bremner
2012-01-25 13:48 ` [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects David Edmondson
[not found] ` <874nvh5tro.fsf@qmul.ac.uk>
2012-01-27 10:28 ` David Edmondson
2012-01-27 13:31 ` Mark Walters
2012-01-27 13:39 ` David Edmondson
2012-01-27 10:32 ` Mark Walters
2012-01-28 5:22 ` Austin Clements
2012-01-27 9:26 ` [PATCH 0/3 v2] minor cleanup and improvements David Edmondson
2012-01-30 10:15 ` [PATCH 0/2 " David Edmondson
2012-01-30 10:16 ` [PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness David Edmondson
2012-01-30 23:46 ` Austin Clements
2012-01-31 6:15 ` David Edmondson
2012-01-30 10:16 ` [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects David Edmondson
2012-01-30 23:48 ` Austin Clements
2012-02-06 7:07 ` Jameson Graef Rollins
2012-02-06 7:47 ` David Edmondson
2012-02-06 8:06 ` Jameson Graef Rollins
2012-02-06 8:56 ` David Edmondson
2012-02-06 19:19 ` Jameson Graef Rollins
2012-02-06 19:34 ` David Edmondson
2012-02-06 19:50 ` Antoine Beaupré
2012-02-28 1:52 ` David Bremner [this message]
2012-01-30 10:18 ` [PATCH 0/2 v2] minor cleanup and improvements David Edmondson
2012-02-04 12:39 ` David Bremner
2012-02-06 21:30 ` [PATCH] emacs: Leave blank subjects alone by default David Edmondson
2012-02-12 20:51 ` Jameson Graef Rollins
2012-02-06 22:48 ` [PATCH v2] " David Edmondson
2012-02-12 8:52 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762eriv15.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=anarcat@anarcat.ath.cx \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).