* [PATCH] emacs: Add compatibility for org-msg.el
@ 2021-06-22 21:48 Ori
2021-06-23 7:56 ` David Edmondson
0 siblings, 1 reply; 6+ messages in thread
From: Ori @ 2021-06-22 21:48 UTC (permalink / raw)
To: notmuch; +Cc: Ori
See https://github.com/jeremy-compostella/org-msg/issues/53
---
NEWS | 2 ++
emacs/notmuch-company.el | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 09456f60..c167c9a2 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,8 @@ Emacs
previous behaviour of using notmuch to send mail by default, customize
`mail-user-agent` to `notmuch-user-agent`.
+`notmuch-company` now works in `org-msg`.
+
Vim
---
diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el
index c6a004ae..7e05dc8f 100644
--- a/emacs/notmuch-company.el
+++ b/emacs/notmuch-company.el
@@ -70,7 +70,8 @@
(completion-ignore-case t))
(cl-case command
(interactive (company-begin-backend 'notmuch-company))
- (prefix (and (derived-mode-p 'message-mode)
+ (prefix (and (or (derived-mode-p 'message-mode)
+ (derived-mode-p 'org-msg-edit-mode))
(looking-back
(concat notmuch-address-completion-headers-regexp ".*")
(line-beginning-position))
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] emacs: Add compatibility for org-msg.el
2021-06-22 21:48 [PATCH] emacs: Add compatibility for org-msg.el Ori
@ 2021-06-23 7:56 ` David Edmondson
2021-06-24 18:20 ` Ori
0 siblings, 1 reply; 6+ messages in thread
From: David Edmondson @ 2021-06-23 7:56 UTC (permalink / raw)
To: Ori, notmuch; +Cc: Ori
On Tuesday, 2021-06-22 at 17:48:50 -04, Ori wrote:
> See https://github.com/jeremy-compostella/org-msg/issues/53
It would be nice to have an inline description of the change, as the
github repository might disappear at some point, but the fix looks
reasonable.
Reviewed-by: David Edmondson <dme@dme.org>
> ---
> NEWS | 2 ++
> emacs/notmuch-company.el | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS b/NEWS
> index 09456f60..c167c9a2 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -8,6 +8,8 @@ Emacs
> previous behaviour of using notmuch to send mail by default, customize
> `mail-user-agent` to `notmuch-user-agent`.
>
> +`notmuch-company` now works in `org-msg`.
> +
> Vim
> ---
>
> diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el
> index c6a004ae..7e05dc8f 100644
> --- a/emacs/notmuch-company.el
> +++ b/emacs/notmuch-company.el
> @@ -70,7 +70,8 @@
> (completion-ignore-case t))
> (cl-case command
> (interactive (company-begin-backend 'notmuch-company))
> - (prefix (and (derived-mode-p 'message-mode)
> + (prefix (and (or (derived-mode-p 'message-mode)
> + (derived-mode-p 'org-msg-edit-mode))
> (looking-back
> (concat notmuch-address-completion-headers-regexp ".*")
> (line-beginning-position))
> --
> 2.25.1
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
dme.
--
There's someone in my head but it's not me.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] emacs: Add compatibility for org-msg.el
2021-06-23 7:56 ` David Edmondson
@ 2021-06-24 18:20 ` Ori
2021-06-24 19:33 ` David Edmondson
0 siblings, 1 reply; 6+ messages in thread
From: Ori @ 2021-06-24 18:20 UTC (permalink / raw)
To: David Edmondson, notmuch
[-- Attachment #1.1: Type: text/plain, Size: 513 bytes --]
Thanks for the suggestion, David. Can the commit message be changed or should I resubmit? An elaborated version:
-------------------------------------------------------------------------------------
Enable `notmuch-company` with `org-msg`, which does not derive from `message-mode` in composing. This change was first proposed in the discussion here: <https://github.com/jeremy-compostella/org-msg/issues/53>
-------------------------------------------------------------------------------------
Thanks,
Ori
[-- Attachment #1.2: Type: text/html, Size: 1386 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] emacs: Add compatibility for org-msg.el
2021-06-24 18:20 ` Ori
@ 2021-06-24 19:33 ` David Edmondson
0 siblings, 0 replies; 6+ messages in thread
From: David Edmondson @ 2021-06-24 19:33 UTC (permalink / raw)
To: Ori, notmuch
On Thursday, 2021-06-24 at 14:20:24 -04, Ori wrote:
> Thanks for the suggestion, David. Can the commit message be changed or
> should I resubmit? An elaborated version:
That's a question for bremner. Re-submitting will probably make his life
easier.
> -------------------------------------------------------------------------------------
>
> Enable `notmuch-company` with `org-msg`, which does not derive from
> `message-mode` in composing. This change was first proposed in the
> discussion here:
> <https://github.com/jeremy-compostella/org-msg/issues/53>
>
> -------------------------------------------------------------------------------------
>
> Thanks,
>
> Ori
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
dme.
--
Hello? Is anybody home? Well, you don't know me, but I know you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] emacs: Add compatibility for org-msg.el
@ 2021-06-24 19:43 Ori
2021-06-24 20:29 ` David Bremner
0 siblings, 1 reply; 6+ messages in thread
From: Ori @ 2021-06-24 19:43 UTC (permalink / raw)
To: notmuch
Enable `notmuch-company` with `org-msg`, which does not derive from
`message-mode` in composing. This change was first proposed in the
discussion here:
https://github.com/jeremy-compostella/org-msg/issues/53
---
NEWS | 2 ++
emacs/notmuch-company.el | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 09456f60..c167c9a2 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,8 @@ Emacs
previous behaviour of using notmuch to send mail by default, customize
`mail-user-agent` to `notmuch-user-agent`.
+`notmuch-company` now works in `org-msg`.
+
Vim
---
diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el
index c6a004ae..7e05dc8f 100644
--- a/emacs/notmuch-company.el
+++ b/emacs/notmuch-company.el
@@ -70,7 +70,8 @@
(completion-ignore-case t))
(cl-case command
(interactive (company-begin-backend 'notmuch-company))
- (prefix (and (derived-mode-p 'message-mode)
+ (prefix (and (or (derived-mode-p 'message-mode)
+ (derived-mode-p 'org-msg-edit-mode))
(looking-back
(concat notmuch-address-completion-headers-regexp ".*")
(line-beginning-position))
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] emacs: Add compatibility for org-msg.el
2021-06-24 19:43 Ori
@ 2021-06-24 20:29 ` David Bremner
0 siblings, 0 replies; 6+ messages in thread
From: David Bremner @ 2021-06-24 20:29 UTC (permalink / raw)
To: Ori, notmuch
Ori <ori@oribarbut.com> writes:
> Enable `notmuch-company` with `org-msg`, which does not derive from
> `message-mode` in composing. This change was first proposed in the
> discussion here:
> https://github.com/jeremy-compostella/org-msg/issues/53
Applied to master, thanks for the updated version
d
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-24 20:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 21:48 [PATCH] emacs: Add compatibility for org-msg.el Ori
2021-06-23 7:56 ` David Edmondson
2021-06-24 18:20 ` Ori
2021-06-24 19:33 ` David Edmondson
-- strict thread matches above, loose matches on Subject: below --
2021-06-24 19:43 Ori
2021-06-24 20:29 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).