From: David Edmondson <dme@dme.org>
To: Jose Antonio Ortega Ruiz <jao@gnu.org>, notmuch@notmuchmail.org
Subject: Re: emacs: honoring notmuch-show-insert-part-text/html for 'w3m renderer
Date: Sat, 31 Jul 2021 10:20:25 +0100 [thread overview]
Message-ID: <cunpmuyn8km.fsf@dme.org> (raw)
In-Reply-To: <87k0l7jsq2.fsf@gnus.jao.io>
On Saturday, 2021-07-31 at 00:18:45 +01, Jose Antonio Ortega Ruiz wrote:
> Hi,
>
> notmuch-show-insert-part-text/html correctly binds shr-blocked-images to
> notmuch-show-text/html-blocked-images when using 'shr as the
> mm-text-html-renderer. However, when the latter is not shr, the
> function only binds gnus-blocked-images, which is not used by the 'w3m
> rendered. The corresponding variable to bind is in the latter case
> w3m-ignored-image-url-regexp, and something like the simple patch below
> seem to make things work, at least for me.
Patch looks good.
Reviewed-by: David Edmondson <dme@dme.org>
> Cheers,
> jao
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 9a95eb34..0c4fc110 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -823,7 +823,8 @@ will return nil if the CID is unknown or cannot be
> retrieved."
> (let ((mm-inline-text-html-with-w3m-keymap nil)
> ;; FIXME: If we block an image, offer a button to load external
> ;; images.
> - (gnus-blocked-images notmuch-show-text/html-blocked-images))
> + (gnus-blocked-images notmuch-show-text/html-blocked-images)
> + (w3m-ignored-image-url-regexp
> notmuch-show-text/html-blocked-images))
> (notmuch-show-insert-part-*/* msg part content-type nth depth
> button))))
>
> ;;; Functions used by notmuch-show--insert-part-text/html-shr
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
next prev parent reply other threads:[~2021-07-31 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 23:18 emacs: honoring notmuch-show-insert-part-text/html for 'w3m renderer Jose Antonio Ortega Ruiz
2021-07-31 9:20 ` David Edmondson [this message]
2021-08-03 22:29 ` David Bremner
2021-08-04 0:03 ` Jose Antonio Ortega Ruiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cunpmuyn8km.fsf@dme.org \
--to=dme@dme.org \
--cc=jao@gnu.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).