From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oFyyNyYXBWGoeQAAgWs5BA (envelope-from ) for ; Sat, 31 Jul 2021 11:25:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iNt3MyYXBWE+cAAA1q6Kng (envelope-from ) for ; Sat, 31 Jul 2021 09:25:58 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 96A431C11 for ; Sat, 31 Jul 2021 11:25:58 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5DBA829245; Sat, 31 Jul 2021 05:25:55 -0400 (EDT) X-Greylist: delayed 324 seconds by postgrey-1.36 at nmbug; Sat, 31 Jul 2021 05:25:53 EDT Received: from wforward3-smtp.messagingengine.com (wforward3-smtp.messagingengine.com [64.147.123.22]) by mail.notmuchmail.org (Postfix) with ESMTPS id 49A9829033 for ; Sat, 31 Jul 2021 05:25:53 -0400 (EDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.west.internal (Postfix) with ESMTP id 0B6D51AC02F0; Sat, 31 Jul 2021 05:20:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 31 Jul 2021 05:20:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/B1PAm HvrKGRc8k3U2EoftfHwEPf6G1v6Hk3uOQICMY=; b=SRfBwnDLnEjhlRCi27cckS 5tSXL62rND9+11t3w8YAbWZclgYEU9ydnxEJUJgTDKkFj1Fk6Cp63kl1uQne3oiP XmcX00WBsUnmvaK2si5qSRBJZ9izMf1IsNTWW3/5Z70IhfJVW9FgQOJJhf3mzo6V bLiw41sxjWQ6q7k8lR0QGP+6mmJlmiJTpP8gbjAKz0IgfGx2vyvnd9iNqTzK40Q6 FTQ4Hpv9xJ0Cu6NT6DOYv8A5FYTotN79jl2EkPUikdeJ8Vzfojc4X59GFZM8NUwK 6KanayeW5xKUmREqOkAkzaz/ThRnnzFfiwk8I08+Cw0sw1oAgssEMtLSQ0zf3e0g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheejgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefvufgjfhfhfffkgggtsehttdertddttddtnecuhfhrohhmpeffrghvihguucfg ughmohhnughsohhnuceoughmvgesughmvgdrohhrgheqnecuggftrfgrthhtvghrnhephf ekgeeutddvgeffffetheejvdejieetgfefgfffudegffffgeduheegteegleeknecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmvgesughmvg drohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 31 Jul 2021 05:20:26 -0400 (EDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 062a700d; Sat, 31 Jul 2021 09:20:25 +0000 (UTC) To: Jose Antonio Ortega Ruiz , notmuch@notmuchmail.org Subject: Re: emacs: honoring notmuch-show-insert-part-text/html for 'w3m renderer In-Reply-To: <87k0l7jsq2.fsf@gnus.jao.io> References: <87k0l7jsq2.fsf@gnus.jao.io> From: David Edmondson Date: Sat, 31 Jul 2021 10:20:25 +0100 Message-ID: MIME-Version: 1.0 Message-ID-Hash: EWETO7M6CHYBL7DOPLJVPDJLVJGMZXYH X-Message-ID-Hash: EWETO7M6CHYBL7DOPLJVPDJLVJGMZXYH X-MailFrom: dme@dme.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627723558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=di5gj+lLF7yahD622KTMn/Gidf6NUEzEDdUf7DlhKUE=; b=GZt0UikGHTuUlPvrVryi6bSwxiFz1uyYY2SOBTjM8cU2RbB5VC7T12zOHVD+u0fOBFfgV7 2+3R/WsSinMzlDzyvEBT5If6kxesB9R0kiLxl58FuoSkn9s61BWRT0P/pRtw6GxY5YRgmV EX+hE/mqJbu2aQw3s3Yd8eebW+T/Knq0MWJsT1/PQY6/8DFFy+B3TQo8W4QEUdki2SCXJ3 POgvCxfiyGvqmVWmbDqYLrqniB/wCSyeiRHGaJHGN4nSg0qFzzMGYO8jQcHv5572K2XPw0 4J9hP9Hxtn7SdrO2MS7OsSm7HuepVAHGfn2Za8kXQkyY7idVIL4K8acc1gNVmg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627723558; a=rsa-sha256; cv=none; b=bcviToRxi9fn3hy4QWKaM4rGWV2QAcqLvj0rdVJQOZRXNDJIBvjuV9M8wvuW+b+iqzOcYS yvcS1copOQw3VXjiG6HBzQsZkjZzBhbvPjK6qQTzNYv/XcjjsOBiB2ASv794EgI54u1oak 9DWgWJdoFGaZ4kjfbZveR2KubCrX3ykbugEpR98FOqGrffpR2poPehZvdHw/PafqUE4rKZ 2eoG6QI34J9cSYQdhnWe3y4qWvlEIO546QXnWG3w0O4MLdXT+39Z27P+dc9dICoarZ/H18 GUJ+daiw8n3uynI77rFuf2E1rUQQqmltGP1WYJnbzqVsgT8NcYzlbop728EQnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=messagingengine.com header.s=fm3 header.b=SRfBwnDL; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=messagingengine.com header.s=fm3 header.b=SRfBwnDL; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 96A431C11 X-Spam-Score: -1.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: KPwjZ+DEQNRR On Saturday, 2021-07-31 at 00:18:45 +01, Jose Antonio Ortega Ruiz wrote: > Hi, > > notmuch-show-insert-part-text/html correctly binds shr-blocked-images to > notmuch-show-text/html-blocked-images when using 'shr as the > mm-text-html-renderer. However, when the latter is not shr, the > function only binds gnus-blocked-images, which is not used by the 'w3m > rendered. The corresponding variable to bind is in the latter case > w3m-ignored-image-url-regexp, and something like the simple patch below > seem to make things work, at least for me. Patch looks good. Reviewed-by: David Edmondson > Cheers, > jao > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 9a95eb34..0c4fc110 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -823,7 +823,8 @@ will return nil if the CID is unknown or cannot be > retrieved." > (let ((mm-inline-text-html-with-w3m-keymap nil) > ;; FIXME: If we block an image, offer a button to load external > ;; images. > - (gnus-blocked-images notmuch-show-text/html-blocked-images)) > + (gnus-blocked-images notmuch-show-text/html-blocked-images) > + (w3m-ignored-image-url-regexp > notmuch-show-text/html-blocked-images)) > (notmuch-show-insert-part-*/* msg part content-type nth depth > button)))) > > ;;; Functions used by notmuch-show--insert-part-text/html-shr > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org