From: David Edmondson <dme@dme.org>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/5] emacs: Allow the indentation of content to be toggled.
Date: Tue, 31 Jan 2012 16:23:32 +0000 [thread overview]
Message-ID: <cunobtjaliz.fsf@hotblack-desiato.hh.sledj.net> (raw)
In-Reply-To: <87d39zu9v4.fsf@qmul.ac.uk>
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
On Tue, 31 Jan 2012 16:15:11 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> Hi I have reviewed the patch series within the limits of my lisp
> knowledge. Patch 1: is rather beyond my lisp so I won't comment on that
> (and I have never tried crypto): Patches 2-5 look fine with one
> bikeshed and one query for my own understanding.
Thanks.
> The bikeshed is that I agree with Jani in
> id:"CAB+hUn8KhXHTRCdrLe0cT=8mdtz9ZntPFf13mq0iCo4CX=B-Jg@mail.gmail.com"
> that I would prefer to reserve '>' for saving a file.
'<' is 'remove indent', or 'look to the left'.
'>' is 'toggle truncation', or 'look to the right'.
(I'm not overly worried about this - would 't' be more acceptable?)
> The query: in
>
> > + (props (notmuch-show-get-message-properties))
> > + (indenting notmuch-show-indent-content))
> > (with-temp-buffer
> > (insert all)
> > - (indent-rigidly (point-min) (point-max) (- depth))
> > + (if indenting
> > + (indent-rigidly (point-min) (point-max) (- depth)))
>
> Is the local variable `indenting' needed because
> notmuch-show-indent-content is buffer local and this is in the
> with-temp-buffer?
Yes.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2012-01-31 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <id:"1327486729-18052-1-git-send-email-dme@dme.org">
2012-01-31 8:46 ` [PATCH 0/5 v4] reworked crypto toggle, plus a few other toggles David Edmondson
2012-01-31 8:46 ` [PATCH 1/5] emacs: Rework crypto switch toggle David Edmondson
2012-01-31 8:46 ` [PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages David Edmondson
2012-01-31 8:46 ` [PATCH 3/5] emacs: Allow the indentation of content to be toggled David Edmondson
2012-01-31 16:15 ` Mark Walters
2012-01-31 16:23 ` David Edmondson [this message]
2012-01-31 23:50 ` Mark Walters
2012-02-01 8:52 ` Tomi Ollila
2012-01-31 8:46 ` [PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines David Edmondson
2012-01-31 8:47 ` [PATCH 5/5] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view' David Edmondson
2012-01-31 8:55 ` [PATCH 0/5 v4] reworked crypto toggle, plus a few other toggles David Edmondson
2012-01-25 10:18 [PATCH 0/3] reworked crypto toggle, plus a couple of " David Edmondson
2012-01-30 16:30 ` [PATCH 0/5 v3] reworked crypto toggle, plus a few " David Edmondson
2012-01-30 16:31 ` [PATCH 3/5] emacs: Allow the indentation of content to be toggled David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cunobtjaliz.fsf@hotblack-desiato.hh.sledj.net \
--to=dme@dme.org \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).