On Tue, 31 Jan 2012 16:15:11 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> Hi I have reviewed the patch series within the limits of my lisp
> knowledge.  Patch 1: is rather beyond my lisp so I won't comment on that
> (and I have never tried crypto): Patches 2-5 look fine with one
> bikeshed and one query for my own understanding.

Thanks.

> The bikeshed is that I agree with Jani in
> id:"CAB+hUn8KhXHTRCdrLe0cT=8mdtz9ZntPFf13mq0iCo4CX=B-Jg@mail.gmail.com"
> that I would prefer to reserve '>' for saving a file.

'<' is 'remove indent', or 'look to the left'.
'>' is 'toggle truncation', or 'look to the right'.

(I'm not overly worried about this - would 't' be more acceptable?)

> The query: in
> 
> > +	 (props (notmuch-show-get-message-properties))
> > +	 (indenting notmuch-show-indent-content))
> >      (with-temp-buffer
> >        (insert all)
> > -      (indent-rigidly (point-min) (point-max) (- depth))
> > +      (if indenting
> > +	  (indent-rigidly (point-min) (point-max) (- depth)))
> 
> Is the local variable `indenting' needed because
> notmuch-show-indent-content is buffer local and this is in the
> with-temp-buffer?

Yes.