From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v6] emacs: Use the new JSON reply format and message-cite-original
Date: Sat, 10 Mar 2012 11:19:40 -0700 [thread overview]
Message-ID: <CAMoJFUuuZ8D+FDpDNuyk0r0qY+JaxciqJ6dJLDZE0N=eyp30aw@mail.gmail.com> (raw)
In-Reply-To: <87aa3p8j1x.fsf@nikula.org>
On Fri, Mar 9, 2012 at 16:13, Jani Nikula <jani@nikula.org> wrote:
>> + (set-mark (point))
>> + (goto-char start)
>> + ;; Quote the original message according to the user's configured style.
>> + (message-cite-original)
>> + (goto-char (point-max)))))
>> +
>> + (push-mark)
>> (message-goto-body)
>> - ;; Original message may contain (malicious) MML tags. We must
>> - ;; properly quote them in the reply. Note that using `point-max'
>> - ;; instead of `mark' here is wrong. The buffer may include user's
>> - ;; signature which should not be MML-quoted.
>> - (mml-quote-region (point) (mark)))
>
> Is it okay to drop mml quoting? Why?
As Austin pointed out on an earlier version, message-cite-original
already does the quoting, so doing it ourselves will result in
double-quoting MML tags.
next prev parent reply other threads:[~2012-03-10 18:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 6:46 [PATCH v6 00/10] Reply improvements Adam Wolfe Gordon
2012-02-22 6:46 ` [PATCH v6 01/10] test: Add broken test for the new JSON reply format Adam Wolfe Gordon
2012-02-22 6:46 ` [PATCH v6 02/10] reply: Factor out reply creation Adam Wolfe Gordon
2012-03-08 22:05 ` Jani Nikula
2012-02-22 6:46 ` [PATCH v6 03/10] reply: Require that only one message is returned Adam Wolfe Gordon
2012-03-09 23:00 ` Jani Nikula
2012-03-10 18:29 ` Adam Wolfe Gordon
2012-03-12 0:29 ` Austin Clements
2012-02-22 6:46 ` [PATCH v6 04/10] TODO: Add replying to multiple messages Adam Wolfe Gordon
2012-02-22 6:46 ` [PATCH v6 05/10] reply: Add a JSON reply format Adam Wolfe Gordon
2012-03-09 23:08 ` Jani Nikula
2012-03-10 18:27 ` Adam Wolfe Gordon
2012-02-22 6:46 ` [PATCH v6 06/10] schemata: Add documentation for " Adam Wolfe Gordon
2012-03-12 0:36 ` Austin Clements
2012-03-12 4:09 ` Adam Wolfe Gordon
2012-03-12 20:57 ` Austin Clements
2012-02-22 6:46 ` [PATCH v6 07/10] man: Update notmuch-reply man page for JSON format Adam Wolfe Gordon
2012-02-22 6:46 ` [PATCH v6 08/10] emacs: Factor out useful functions into notmuch-lib Adam Wolfe Gordon
2012-02-22 6:46 ` [PATCH v6 09/10] test: Add broken tests for new emacs reply functionality Adam Wolfe Gordon
2012-02-22 6:46 ` [PATCH v6] emacs: Use the new JSON reply format and message-cite-original Adam Wolfe Gordon
2012-03-09 23:13 ` Jani Nikula
2012-03-10 18:19 ` Adam Wolfe Gordon [this message]
2012-03-12 1:11 ` Austin Clements
2012-02-25 21:29 ` [PATCH v6 00/10] Reply improvements David Bremner
2012-02-25 22:25 ` Adam Wolfe Gordon
2012-02-26 0:23 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMoJFUuuZ8D+FDpDNuyk0r0qY+JaxciqJ6dJLDZE0N=eyp30aw@mail.gmail.com' \
--to=awg+notmuch@xvx.ca \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).