unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v6 03/10] reply: Require that only one message is returned
Date: Sun, 11 Mar 2012 20:29:36 -0400	[thread overview]
Message-ID: <20120312002936.GA2754@mit.edu> (raw)
In-Reply-To: <87fwdh8jmh.fsf@nikula.org>

Quoth Jani Nikula on Mar 10 at  1:00 am:
> On Tue, 21 Feb 2012 23:46:32 -0700, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:
> > As the semantics of replying to multiple messages have not yet been
> > defined well, make notmuch reply require that the search given returns
> > only a single message.
> 
> Is there any real reason, apart from consistency between
> --format=default and --format=json, to disable the current multiple
> message reply? Also "notmuch show" has format specific features and
> limitations.
> 
> I agree the semantics should be clarified, and eventually multiple
> message reply should be uniformly supported by all formats, including
> --format=json, but IMHO this patch should be dropped (and the TODO patch
> amended accordingly).

I agree with Jani.  We might as well leave the existing format as it
is and say in the TODO that we should both fix multiple reply and
support it in the JSON format.

> BR,
> Jani.

  parent reply	other threads:[~2012-03-12  0:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22  6:46 [PATCH v6 00/10] Reply improvements Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 01/10] test: Add broken test for the new JSON reply format Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 02/10] reply: Factor out reply creation Adam Wolfe Gordon
2012-03-08 22:05   ` Jani Nikula
2012-02-22  6:46 ` [PATCH v6 03/10] reply: Require that only one message is returned Adam Wolfe Gordon
2012-03-09 23:00   ` Jani Nikula
2012-03-10 18:29     ` Adam Wolfe Gordon
2012-03-12  0:29     ` Austin Clements [this message]
2012-02-22  6:46 ` [PATCH v6 04/10] TODO: Add replying to multiple messages Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 05/10] reply: Add a JSON reply format Adam Wolfe Gordon
2012-03-09 23:08   ` Jani Nikula
2012-03-10 18:27     ` Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 06/10] schemata: Add documentation for " Adam Wolfe Gordon
2012-03-12  0:36   ` Austin Clements
2012-03-12  4:09     ` Adam Wolfe Gordon
2012-03-12 20:57       ` Austin Clements
2012-02-22  6:46 ` [PATCH v6 07/10] man: Update notmuch-reply man page for JSON format Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 08/10] emacs: Factor out useful functions into notmuch-lib Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6 09/10] test: Add broken tests for new emacs reply functionality Adam Wolfe Gordon
2012-02-22  6:46 ` [PATCH v6] emacs: Use the new JSON reply format and message-cite-original Adam Wolfe Gordon
2012-03-09 23:13   ` Jani Nikula
2012-03-10 18:19     ` Adam Wolfe Gordon
2012-03-12  1:11   ` Austin Clements
2012-02-25 21:29 ` [PATCH v6 00/10] Reply improvements David Bremner
2012-02-25 22:25   ` Adam Wolfe Gordon
2012-02-26  0:23     ` Austin Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120312002936.GA2754@mit.edu \
    --to=amdragon@mit.edu \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).