Re: [PATCH] emacs: keep customizations in groups

[Jani Nikula <jani@nikula.org>]

[-- Attachment #1: Type: text/plain, Size: 2383 bytes --]

On Mar 5, 2012 1:50 AM, "Mark Walters" <markwalters1009@gmail.com> wrote:
>
> On Sat,  3 Mar 2012 23:55:24 +0200, Jani Nikula <jani@nikula.org> wrote:
> > Move hello section customization to notmuch-hello group and printing
> > customization to notmuch-show group from the top level customization
> > group.
>
> Hi
>
> This is an clear improvement but I wonder about the positioning of these
> two options inside the subgroups. It makes
>
> notmuch-hello-sections the last option under notmuch-hello and
>
> notmuch-print-mechanism the first option under notmuch-show
>
> both of which seem slightly strange positions.
>
> (Personally I would place notmuch-hello-sections towards the top, and
> notmuch-print-mechanism towards the bottom. If you decided on this
> ordering then I am happy to go with it: I am only commenting in case it
> is just accidental.)

I just changed the groups, and that's where the options landed... I don't
know how to change the order.

>
> Best wishes
>
> Mark
>
>
>
> > ---
> >  emacs/notmuch-hello.el |    2 +-
> >  emacs/notmuch-print.el |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> > index e089290..0cf613f 100644
> > --- a/emacs/notmuch-hello.el
> > +++ b/emacs/notmuch-hello.el
> > @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count
of messages
> >  displayed next to the buttons can be generated by applying a
> >  different filter to the tag query. These filters are also
> >  supported for \"Customized queries section\" items."
> > -  :group 'notmuch
> > +  :group 'notmuch-hello
> >    :type
> >    '(repeat
> >      (choice (function-item notmuch-hello-insert-header)
> > diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
> > index 6653d97..8c18f4b 100644
> > --- a/emacs/notmuch-print.el
> > +++ b/emacs/notmuch-print.el
> > @@ -25,7 +25,7 @@
> >
> >  (defcustom notmuch-print-mechanism 'notmuch-print-lpr
> >    "How should printing be done?"
> > -  :group 'notmuch
> > +  :group 'notmuch-show
> >    :type '(choice
> >         (function :tag "Use lpr" notmuch-print-lpr)
> >         (function :tag "Use ps-print" notmuch-print-ps-print)
> > --
> > 1.7.5.4
> >
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch

[-- Attachment #2: Type: text/html, Size: 3392 bytes --]