From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: keep customizations in groups
Date: Sun, 04 Mar 2012 23:52:35 +0000 [thread overview]
Message-ID: <87d38r6i0s.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1330811724-30901-1-git-send-email-jani@nikula.org>
On Sat, 3 Mar 2012 23:55:24 +0200, Jani Nikula <jani@nikula.org> wrote:
> Move hello section customization to notmuch-hello group and printing
> customization to notmuch-show group from the top level customization
> group.
Hi
This is an clear improvement but I wonder about the positioning of these
two options inside the subgroups. It makes
notmuch-hello-sections the last option under notmuch-hello and
notmuch-print-mechanism the first option under notmuch-show
both of which seem slightly strange positions.
(Personally I would place notmuch-hello-sections towards the top, and
notmuch-print-mechanism towards the bottom. If you decided on this
ordering then I am happy to go with it: I am only commenting in case it
is just accidental.)
Best wishes
Mark
> ---
> emacs/notmuch-hello.el | 2 +-
> emacs/notmuch-print.el | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index e089290..0cf613f 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count of messages
> displayed next to the buttons can be generated by applying a
> different filter to the tag query. These filters are also
> supported for \"Customized queries section\" items."
> - :group 'notmuch
> + :group 'notmuch-hello
> :type
> '(repeat
> (choice (function-item notmuch-hello-insert-header)
> diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
> index 6653d97..8c18f4b 100644
> --- a/emacs/notmuch-print.el
> +++ b/emacs/notmuch-print.el
> @@ -25,7 +25,7 @@
>
> (defcustom notmuch-print-mechanism 'notmuch-print-lpr
> "How should printing be done?"
> - :group 'notmuch
> + :group 'notmuch-show
> :type '(choice
> (function :tag "Use lpr" notmuch-print-lpr)
> (function :tag "Use ps-print" notmuch-print-ps-print)
> --
> 1.7.5.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-03-04 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 21:55 [PATCH] emacs: keep customizations in groups Jani Nikula
2012-03-04 23:52 ` Mark Walters [this message]
[not found] ` <CAB+hUn8J=Hd1ASOw9oga=2L1Au4nCjc3FszjP6SnK438tPXj8A@mail.gmail.com>
2012-03-05 7:24 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d38r6i0s.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).